qa: Make wallet_multiwallet.py Windows-compatible #34418

1. 
   hodlinator commented at 12:35 pm on January 27, 2026: contributor

   Main parts:

   • Commit “qa: Check for platform-independent part of error message” switches to match on platform-independent part of error message.
   • Commit “qa: Test scanning errors individually” disentangles code causing the same error message substring, based on #31410.
   • Commit “qa: Disable parts of the test when running under Windows or root” enables the test to be run on Windows, based in part on #31410 (comment).

   Also:

   • Removes unused option in wallet_multiwallet.py.
   • Breaks apart wallet_multiwallet.py’s run_test() into smaller test functions.
   • Improves assert_equal() output for dicts.

   Fixes #31409.

2. refactor(qa): Remove unused option

   Last use was removed in 0d32d661481f099af572e7a08a50e17bcc165c44.

   4d0b3b88c8
3. scripted-diff: self.nodes[0] => node

   -BEGIN VERIFY SCRIPT-
   sed --in-place 's/self\.nodes\[0\]/node/g; s/node \= node/node \= self\.nodes\[0\]/' ./test/functional/wallet_multiwallet.py
   -END VERIFY SCRIPT-

   7f429ee91c
4. refactor(qa): Lift out functions to outer scopes

   This prepares for later breaking apart of run_test().
   
   Note that the "wallet" lambda was renamed to "get_wallet" since otherwise the Python interpreter emitted:
   "UnboundLocalError: cannot access local variable 'wallet' where it is not associated with a value"

   32e2effaac
5. move-only(qa): Move wallet creation check down to others

   Makes the functions broken out from run_test() in the next commit more cohesive.

   0cabd3c7b0
6. refactor(qa): Break apart ginormous run_test() 6a652d999b
7. qa: Check for platform-independent part of error message

   On Windows one gets different exception messages depending on whether running a native build or cross build.

   2c4c4f0ab0
8. qa: Test scanning errors individually

   This change ensures that each condition potentially triggering the
   "Error while scanning" log message is tested independently, avoiding
   false positives.
   
   Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

   3f552ae764
9. qa: Disable parts of the test when running under Windows or root

   test_scanning_sub_dir():
   - Remove try/finally - we don't need to clean up after a failed test (done in this commit to maintain indentation).
   
   Regarding symlinks: https://github.com/bitcoin/bitcoin/pull/31410#issuecomment-3554721014
   
   Co-authored-by: Ava Chow <github@achow101.com>

   a36aae2f40
10. ci: Enable `wallet_multiwallet.py` in "Windows, test cross-built" job abf373ec4e
11. qa: Avoid duplicating output in case the diff is the same 596752a06d
12. DrahtBot added the label Tests on Jan 27, 2026
13. 
    DrahtBot commented at 12:35 pm on January 27, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34418.

    Reviews

    See the guideline for information on the review process.

    Type	Reviewers
    Concept ACK	hebasto
    Approach ACK	w0xlt

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

14. hodlinator renamed this:
    qa: Make `wallet_multiwallet.py` Windows-compatible
    qa: Make wallet_multiwallet.py Windows-compatible
    on Jan 27, 2026
15. 
    hebasto commented at 3:29 pm on January 27, 2026: member

    Concept ACK.

    Thanks for taking this over!

16. 
    w0xlt commented at 10:22 pm on January 27, 2026: contributor

    Approach ACK. I’ll review it more closely soon.

Contributors
hodlinator DrahtBot hebasto w0xlt

Labels
Tests