lint: Flatten lint image entry points #34427

1. 
   maflcko commented at 10:09 am on January 28, 2026: member

   Two fixups to the lint container:

   • Add a missing --platform=linux to avoid running a non-native arch, like s390x, which happens with podman if such a container was most recently used.
   • Flatten the entry points to remove the bash-based one:

   Previously, an additional entry point into the container that spawned a bash was supported. The bash had an alias lint to run all lint scripts. However, such a use-case seems limited (because it only runs inside the container), inflexible (because it only allows running all lint scripts), and possibly brittle (because it can miss re-building the image when the cache is stale). So remove it and just offer the single entry point via the ./ci/lint.py script.

   If there is a use-case to skip the image building, it should be trivial to add an env var setting the the lint Python script like DANGER_SKIP_IMAGE_RE_BUILD=1 (or so) in the future.

2. DrahtBot renamed this:
   lint: Flatten lint image entry points
   lint: Flatten lint image entry points
   on Jan 28, 2026
3. DrahtBot added the label Tests on Jan 28, 2026
4. 
   DrahtBot commented at 10:09 am on January 28, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34427.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	willcl-ark

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #33051 (Don’t fix Python patch version by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   maflcko commented at 10:22 am on January 28, 2026: member

   The first commit can be tested by running:

    0sh-5.1# docker run --rm --platform=linux/s390x mirror.gcr.io/ubuntu:24.04 uname --machine
    1Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
    2s390x
    3
    4sh-5.1# ./ci/lint.py
    5+ docker buildx build --tag=bitcoin-linter --file=/root/b-c-ci-dbg/ci/lint_imagefile /root/b-c-ci-dbg
    6Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
    7STEP 1/6: FROM mirror.gcr.io/ubuntu:24.04
    8WARNING: image platform (linux/s390x) does not match the expected platform (linux/amd64)
    9STEP 2/6: COPY ./ci/retry/retry /ci_retry
   10^C
   

   On master it will pick s390x for the image. With this pull, it will pick amd64.

6. maflcko force-pushed on Jan 28, 2026
7. DrahtBot added the label CI failed on Jan 28, 2026
8. DrahtBot removed the label CI failed on Jan 28, 2026
9. DrahtBot added the label Needs rebase on Jan 28, 2026
10. lint: Add missing --platform=linux to docker build command

    Otherwise, this may pick the wrong arch like s390x, if a such a podman
    container was most recently used.
    
    See also the CI_IMAGE_PLATFORM setting in the "other" CI, which does the
    same.

    1111fff91c
11. maflcko force-pushed on Jan 28, 2026
12. lint: Flatten lint image entry points faba426b3b
13. maflcko force-pushed on Jan 28, 2026
14. DrahtBot removed the label Needs rebase on Jan 28, 2026
15. willcl-ark approved
16. 
    willcl-ark commented at 2:09 pm on January 29, 2026: member

    ACK faba426b3b666c0e93e4349ba88deb79517534c6

    nice tidy up, thanks!

17. fanquake requested review from davidgumberg on Jan 30, 2026

Contributors
maflcko DrahtBot willcl-ark

Review Requested
davidgumberg

Labels
Tests