test: Check that redundant verack message is ignored #34429

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2601-test-red-verack changing 1 files +8 −0
  1. maflcko commented at 12:08 pm on January 28, 2026: member
    The code exists and is uncovered (ref https://maflcko.github.io/b-c-cov/total.coverage/src/net_processing.cpp.gcov.html#L3795), so add a trivial test to cover it.
  2. test: Check that redundant verack message is ignored fafdae46ff
  3. DrahtBot added the label Tests on Jan 28, 2026
  4. DrahtBot commented at 12:08 pm on January 28, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK brunoerg, sedited

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  5. brunoerg commented at 3:59 pm on January 28, 2026: contributor

    Strangely, corecheck doesn’t seem to show this new coverage.

  6. maflcko commented at 4:11 pm on January 28, 2026: member
    Yeah, i think corecheck coverage is fully broken for a while now. See https://github.com/corecheck/corecheck/issues/150 . I’ve removed it via https://github.com/maflcko/DrahtBot/commit/f2e2df2ec8928af269a49f383d13212f8018623d
  7. brunoerg approved
  8. brunoerg commented at 6:00 pm on January 29, 2026: contributor
    ACK fafdae46ff0b02d93d5fcff35f1185627d11d76a
  9. sedited approved
  10. sedited commented at 8:29 am on January 30, 2026: contributor
    ACK fafdae46ff0b02d93d5fcff35f1185627d11d76a
  11. sedited merged this on Jan 30, 2026
  12. sedited closed this on Jan 30, 2026

  13. maflcko deleted the branch on Jan 30, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-02-01 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me