The code exists and is uncovered (ref https://maflcko.github.io/b-c-cov/total.coverage/src/net_processing.cpp.gcov.html#L3795), so add a trivial test to cover it.
test: Check that redundant verack message is ignored #34429
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2601-test-red-verack changing 1 files +8 −0-
maflcko commented at 12:08 PM on January 28, 2026: member
-
test: Check that redundant verack message is ignored fafdae46ff
- DrahtBot added the label Tests on Jan 28, 2026
-
DrahtBot commented at 12:08 PM on January 28, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
-
brunoerg commented at 3:59 PM on January 28, 2026: contributor
Strangely, corecheck doesn't seem to show this new coverage.
<img width="1142" height="358" alt="image" src="https://github.com/user-attachments/assets/85d8e59f-7b33-40c8-9887-6553d9e2e8a5" />
-
maflcko commented at 4:11 PM on January 28, 2026: member
Yeah, i think corecheck coverage is fully broken for a while now. See https://github.com/corecheck/corecheck/issues/150 . I've removed it via https://github.com/maflcko/DrahtBot/commit/f2e2df2ec8928af269a49f383d13212f8018623d
<!-- NACK
- brunoerg approved
-
brunoerg commented at 6:00 PM on January 29, 2026: contributor
ACK fafdae46ff0b02d93d5fcff35f1185627d11d76a
- sedited approved
-
sedited commented at 8:29 AM on January 30, 2026: contributor
ACK fafdae46ff0b02d93d5fcff35f1185627d11d76a
- sedited merged this on Jan 30, 2026
- sedited closed this on Jan 30, 2026
- maflcko deleted the branch on Jan 30, 2026
