ci, iwyu: Fix warnings in src/univalue and treat them as errors #34455

1. 
   hebasto commented at 11:30 pm on January 29, 2026: member

   This PR continues the ongoing effort to enforce IWYU warnings.

   See Developer Notes.

2. hebasto added the label Refactoring on Jan 29, 2026
3. 
   DrahtBot commented at 11:30 pm on January 29, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, sedited

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

4. DrahtBot added the label Needs rebase on Jan 31, 2026
5. ci, iwyu: Fix warnings in `src/univalue` and treat them as errors 1bf3842223
6. hebasto force-pushed on Jan 31, 2026
7. 
   hebasto commented at 10:44 am on January 31, 2026: member

   Rebased to resolve a conflict with merged bitcoin/bitcoin#34338.
8. 
   maflcko commented at 12:18 pm on January 31, 2026: member

   It would be good to only have one open pull request here at any point in time. Otherwise, they’ll just conflict and drain a bit of review. Also, the link to my comment in another pull can probably removed (it doesn’t mention univalue). I think just linking to the dev notes is enough.

   review ACK 1bf384222323885ffafb669042d97a4fc5327586 🦇

   Signature:

   0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
   1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
   2trusted comment: review ACK 1bf384222323885ffafb669042d97a4fc5327586 🦇
   3ZXxiyGL7rrzZmS2LABJPnmzlQrOssPxRhLJ3vVZBsAF1EJ1dVLY9XJu6Noo1vfZDBtu6jqXlYUY7d9l6cIxICg==
   

9. DrahtBot removed the label Needs rebase on Jan 31, 2026
10. sedited approved
11. 
    sedited commented at 1:46 pm on January 31, 2026: contributor

    ACK 1bf384222323885ffafb669042d97a4fc5327586
12. 
    hebasto commented at 1:51 pm on January 31, 2026: member

    It would be good to only have one open pull request here at any point in time. Otherwise, they’ll just conflict and drain a bit of review.

    My apologies. I’ll follow your advice in the future.

    Also, the link to my comment in another pull can probably removed (it doesn’t mention univalue). I think just linking to the dev notes is enough.

    Amended.

13. sedited merged this on Jan 31, 2026
14. sedited closed this on Jan 31, 2026

    ---

15. hebasto deleted the branch on Jan 31, 2026

Contributors
hebasto DrahtBot maflcko sedited

Labels
Refactoring