This PR continues the ongoing effort to enforce IWYU warnings.
See Developer Notes.
ci, iwyu: Fix warnings in `src/univalue` and treat them as errors #34455
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260129-iwyu-univalue changing 7 files +3 −10-
hebasto commented at 11:30 PM on January 29, 2026: member
- hebasto added the label Refactoring on Jan 29, 2026
-
DrahtBot commented at 11:30 PM on January 29, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label Needs rebase on Jan 31, 2026
-
ci, iwyu: Fix warnings in `src/univalue` and treat them as errors 1bf3842223
- hebasto force-pushed on Jan 31, 2026
-
hebasto commented at 10:44 AM on January 31, 2026: member
Rebased to resolve a conflict with merged bitcoin/bitcoin#34338.
-
maflcko commented at 12:18 PM on January 31, 2026: member
It would be good to only have one open pull request here at any point in time. Otherwise, they'll just conflict and drain a bit of review. Also, the link to my comment in another pull can probably removed (it doesn't mention univalue). I think just linking to the dev notes is enough.
review ACK 1bf384222323885ffafb669042d97a4fc5327586 🦇
<details><summary>Show signature</summary>
Signature:
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}" RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM= trusted comment: review ACK 1bf384222323885ffafb669042d97a4fc5327586 🦇 ZXxiyGL7rrzZmS2LABJPnmzlQrOssPxRhLJ3vVZBsAF1EJ1dVLY9XJu6Noo1vfZDBtu6jqXlYUY7d9l6cIxICg==</details>
- DrahtBot removed the label Needs rebase on Jan 31, 2026
- sedited approved
-
sedited commented at 1:46 PM on January 31, 2026: contributor
ACK 1bf384222323885ffafb669042d97a4fc5327586
-
hebasto commented at 1:51 PM on January 31, 2026: member
It would be good to only have one open pull request here at any point in time. Otherwise, they'll just conflict and drain a bit of review.
My apologies. I'll follow your advice in the future.
Also, the link to my comment in another pull can probably removed (it doesn't mention univalue). I think just linking to the dev notes is enough.
Amended.
- sedited merged this on Jan 31, 2026
- sedited closed this on Jan 31, 2026
- hebasto deleted the branch on Jan 31, 2026
Labels