ci: Print verbose build error message in test-each-commit #34461

1. 
   maflcko commented at 12:12 pm on January 30, 2026: member

   Currently, the build error in the test-each-commit task is not too nice. E.g. https://github.com/bitcoin/bitcoin/actions/runs/21509735101/job/61973587699#step:8:10464:

    0...
    1[ 75%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/txvalidation_tests.cpp.o
    2[ 75%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/txvalidationcache_tests.cpp.o
    3[ 75%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/validation_block_tests.cpp.o
    4[ 75%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/validation_chainstate_tests.cpp.o
    5[ 75%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/validation_chainstatemanager_tests.cpp.o
    6[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/validation_flush_tests.cpp.o
    7[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/validation_tests.cpp.o
    8[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_test_fixture.cpp.o
    9[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/db_tests.cpp.o
   10[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselector_tests.cpp.o
   11[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/coinselection_tests.cpp.o
   12[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/feebumper_tests.cpp.o
   13[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/group_outputs_tests.cpp.o
   14[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/ismine_tests.cpp.o
   15[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/psbt_wallet_tests.cpp.o
   16[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/scriptpubkeyman_tests.cpp.o
   17[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/spend_tests.cpp.o
   18[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_rpc_tests.cpp.o
   19[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
   20[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_transaction_tests.cpp.o
   21[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletdb_tests.cpp.o
   22[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/walletload_tests.cpp.o
   23[ 76%] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/ipc/test/ipc_tests.cpp.o
   24[ 77%] Linking CXX executable ../../bin/test_bitcoin
   25[ 87%] Built target test_bitcoin
   26gmake: *** [Makefile:146: all] Error 2
   27Command '['cmake', '--build', 'ci_build', '-j', '4']' returned non-zero exit status 2.
   28error: cannot rebase: Your index contains uncommitted changes.
   29warning: execution failed: git merge --no-commit origin/master && python3 ./.github/ci-test-each-commit-exec.py && git reset --hard
   30and made changes to the index and/or the working tree.
   31You can fix the problem, and then run
   32
   33  git rebase --continue
   34
   35
   36Error: Process completed with exit code 1.
   

   Fix it by just using the same approach that the other CI tasks are using:

   https://github.com/bitcoin/bitcoin/blob/01651324f4e540f6b96cff31e89752c3f9417293/ci/test/03_test_script.sh#L143-L146

2. ci: [refactor] Allow overwriting check option in run helper

   Also, use str(e) consistently in all run helpers.
   
   This refactor does not change any behavior.
   
   This can be reviewed by checking that all instances are exactly
   identical code now:
   $ git grep --function-context 'def run(cmd'

   2222dadabb
3. ci: Print verbose build error message in test-each-commit bbbb78a4f2
4. DrahtBot renamed this:
   ci: Print verbose build error message in test-each-commit
   ci: Print verbose build error message in test-each-commit
   on Jan 30, 2026
5. DrahtBot added the label Tests on Jan 30, 2026
6. 
   DrahtBot commented at 12:12 pm on January 30, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

7. fanquake added the label Needs backport (30.x) on Jan 30, 2026

Contributors
maflcko DrahtBot

Labels
Tests Needs backport (30.x)