Update secp256k1 subtree to latest master

fanquake commented at 12:50 pm on February 2, 2026: member

Updates the secp256k1 subtree to latest master (https://github.com/bitcoin-core/secp256k1/commit/57315a69853c9bd4765fccf20b541d47f1b45ca9), which includes https://github.com/bitcoin-core/secp256k1/pull/1813.

DrahtBot commented at 12:50 pm on February 2, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, maflcko

If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

maflcko commented at 1:40 pm on February 2, 2026: member

Could roll #34442 into this pull?

Squashed 'src/secp256k1/' changes from 14e56970cb..57315a6985

57315a6985 Merge bitcoin-core/secp256k1#1813: Remove trailing spaces and introduce `-Wtrailing-whitespace=any` compiler flag
86cae58d2f build: Add `-Wleading-whitespace=spaces` compiler flag
fb229e7602 build: Add `-Wtrailing-whitespace=any` compiler flag
13e3bee504 refactor: Remove trailing whitespace
453949ab2a Merge bitcoin-core/secp256k1#1816: ci: Rotate Docker cache keys
cd49c57e44 Merge bitcoin-core/secp256k1#1814: release process: mention the `[Unreleased]` link clearly
2ccff6eb73 ci: Add weekly schedule
2f18567d24 ci: Rotate Docker cache keys every 4 weeks
0ffb1749a5 ci, docker: Fix LLVM repository signature failure
0267b65512 release process: mention the `[Unreleased]` link clearly
1605b02f75 Merge bitcoin-core/secp256k1#1775: Add CMake build directory patterns to `.gitignore`
748c0fdd67 Add CMake build directory patterns to `.gitignore`
7eb86bdb01 autotools: Rename `build-aux` to `autotools-aux`

git-subtree-dir: src/secp256k1
git-subtree-split: 57315a69853c9bd4765fccf20b541d47f1b45ca9

9d4c9b0035

Update secp256k1 subtree to latest master 1ed3de5a6d

ci: detect apk usage generally

Rather than listing image names, which makes it less easy to
run custom CI jobs.

1cee0e4cd3

ci: use Alpine 3.23 d405713197

fanquake force-pushed on Feb 2, 2026

fanquake commented at 3:22 pm on February 2, 2026: member

Could roll #34442 into this pull?

Updated now that https://github.com/bitcoin-core/secp256k1/pull/1813 is merged, and pulled in #34442.

fanquake marked this as ready for review on Feb 2, 2026

hebasto approved

hebasto commented at 5:41 pm on February 2, 2026: member

ACK d405713197f857d3a630ab52117e08ee7ae00789.

My Guix build:

 0aarch64
 1c2eaad07823f7aa4c51992f735eab1481cc2b10133ebeb63a684f02cd63b2874  guix-build-d405713197f8/output/aarch64-linux-gnu/SHA256SUMS.part
 2fd6f46e38e310311446cd31b1c3797a278b4e71653f5b3ad945beeefe2543932  guix-build-d405713197f8/output/aarch64-linux-gnu/bitcoin-d405713197f8-aarch64-linux-gnu-debug.tar.gz
 3acfc8320209abfa9c561bf84275f165a4e14f74ac84c72a58307a04bbff56d66  guix-build-d405713197f8/output/aarch64-linux-gnu/bitcoin-d405713197f8-aarch64-linux-gnu.tar.gz
 45109a29c97341f01e01a393709b64d4a36b767436e88a2cfb6fb118d9aa73c12  guix-build-d405713197f8/output/arm-linux-gnueabihf/SHA256SUMS.part
 553f161f75428422ff2994842084b656bea000ffa3a81a72ba1b85aa79dfa8598  guix-build-d405713197f8/output/arm-linux-gnueabihf/bitcoin-d405713197f8-arm-linux-gnueabihf-debug.tar.gz
 66b0f2aed48d54474fc9fec7cca7f98861ebf17ea70ccf076da88669bde0f048b  guix-build-d405713197f8/output/arm-linux-gnueabihf/bitcoin-d405713197f8-arm-linux-gnueabihf.tar.gz
 7c03352c7fd3861745be88a6399e55d7e6953e0839b6e1f3bf14d9b2184396bc4  guix-build-d405713197f8/output/arm64-apple-darwin/SHA256SUMS.part
 8741191aefb3c8247156cf22d9cbb270287a9cb54e8965cc9a0af7d671b701593  guix-build-d405713197f8/output/arm64-apple-darwin/bitcoin-d405713197f8-arm64-apple-darwin-codesigning.tar.gz
 99cd2b53d46b60ec535abd161a33f07668137cd71f43c7508f5a749eb3a325e58  guix-build-d405713197f8/output/arm64-apple-darwin/bitcoin-d405713197f8-arm64-apple-darwin-unsigned.tar.gz
10a6ae136a52c82d9bfd6a1844d4227d916e81a52de5a4fbfd5605d8400ff98b51  guix-build-d405713197f8/output/arm64-apple-darwin/bitcoin-d405713197f8-arm64-apple-darwin-unsigned.zip
115b6ca195d66b0917270a5485ecd8dd890931f506a0e22a37f3188bf53f1de141  guix-build-d405713197f8/output/dist-archive/bitcoin-d405713197f8.tar.gz
125d80313c02962d5ffdb19387f2b76b13f8491ea4bc59c03226f7e5db8565a564  guix-build-d405713197f8/output/powerpc64-linux-gnu/SHA256SUMS.part
130ffa66189ac95c054b656fee378bbc25fa0aa9ef438e6257c1f874a531e41276  guix-build-d405713197f8/output/powerpc64-linux-gnu/bitcoin-d405713197f8-powerpc64-linux-gnu-debug.tar.gz
142ae364a990314ac35f8884720d0be7ad019b00b05fc100da5a0fe176cb54f225  guix-build-d405713197f8/output/powerpc64-linux-gnu/bitcoin-d405713197f8-powerpc64-linux-gnu.tar.gz
15cd2806921d5f49f012619aef123340f9f30860065cc069f97c8a6638ea43c60e  guix-build-d405713197f8/output/riscv64-linux-gnu/SHA256SUMS.part
16478699e086ee81448646700189edb073d1fbb18ebcdfa8130aec3d0388dae730  guix-build-d405713197f8/output/riscv64-linux-gnu/bitcoin-d405713197f8-riscv64-linux-gnu-debug.tar.gz
1763fd4467e0930deaf5926c4364e74b668c676133ec2033c2c8c0a9515eadc96b  guix-build-d405713197f8/output/riscv64-linux-gnu/bitcoin-d405713197f8-riscv64-linux-gnu.tar.gz
1848716ce0608835b72cb3266ef8a4833c43ddb327f6dc608061c9d4e4e49b0415  guix-build-d405713197f8/output/x86_64-apple-darwin/SHA256SUMS.part
19352ba462d65eaa99f20211962f4334233989fe0541971ed22f354d9f39730035  guix-build-d405713197f8/output/x86_64-apple-darwin/bitcoin-d405713197f8-x86_64-apple-darwin-codesigning.tar.gz
20b5e766d45158875e6bd440ce2269fbd9fc4e3f9af0a30a45bf52f9776e8ceb95  guix-build-d405713197f8/output/x86_64-apple-darwin/bitcoin-d405713197f8-x86_64-apple-darwin-unsigned.tar.gz
21a0f1c6d39b8fcb95dd478746f0178efec8a3391485d8ee671bfa7d2f4da5e48c  guix-build-d405713197f8/output/x86_64-apple-darwin/bitcoin-d405713197f8-x86_64-apple-darwin-unsigned.zip
220edc13ecfc22723ebe7d974439813ee2f398978be128c3878a844410f791835e  guix-build-d405713197f8/output/x86_64-linux-gnu/SHA256SUMS.part
23dc4df3e11d224afefe79d549a270b7cd35659e422f7d067aae27cd4fa46fbcc4  guix-build-d405713197f8/output/x86_64-linux-gnu/bitcoin-d405713197f8-x86_64-linux-gnu-debug.tar.gz
24f5b0f63e03a2bd739563b658dd7a7bc89288dba83598430bd446f399a868da39  guix-build-d405713197f8/output/x86_64-linux-gnu/bitcoin-d405713197f8-x86_64-linux-gnu.tar.gz
2529c65fad74eadbaf8c989325f9dc3355a59e5962706027fe7ae9a9b7659d014d  guix-build-d405713197f8/output/x86_64-w64-mingw32/SHA256SUMS.part
269144e9892ade0c610f24ee414e42d183768582e527852bbc279530d0b7617e11  guix-build-d405713197f8/output/x86_64-w64-mingw32/bitcoin-d405713197f8-win64-codesigning.tar.gz
27d22d2e852e8f2f7fa412c8cadf4c291d270c00dd6796ad59874fc600b1fef76d  guix-build-d405713197f8/output/x86_64-w64-mingw32/bitcoin-d405713197f8-win64-debug.zip
28debb8f755925ef0b858c5073c37232a18f3747afce130f5806755486012ff949  guix-build-d405713197f8/output/x86_64-w64-mingw32/bitcoin-d405713197f8-win64-setup-unsigned.exe
29d2427c46747e5fecc8b831052d906a4cc6ff3af15697c094b52a128d36666985  guix-build-d405713197f8/output/x86_64-w64-mingw32/bitcoin-d405713197f8-win64-unsigned.zip

fanquake requested review from maflcko on Feb 3, 2026

maflcko commented at 10:24 am on February 3, 2026: member

lgtm ACK d405713197f857d3a630ab52117e08ee7ae00789

fanquake commented at 10:48 am on February 3, 2026: member

Guix Build x86_64:

 0c2eaad07823f7aa4c51992f735eab1481cc2b10133ebeb63a684f02cd63b2874  guix-build-d405713197f8/output/aarch64-linux-gnu/SHA256SUMS.part
 1fd6f46e38e310311446cd31b1c3797a278b4e71653f5b3ad945beeefe2543932  guix-build-d405713197f8/output/aarch64-linux-gnu/bitcoin-d405713197f8-aarch64-linux-gnu-debug.tar.gz
 2acfc8320209abfa9c561bf84275f165a4e14f74ac84c72a58307a04bbff56d66  guix-build-d405713197f8/output/aarch64-linux-gnu/bitcoin-d405713197f8-aarch64-linux-gnu.tar.gz
 35109a29c97341f01e01a393709b64d4a36b767436e88a2cfb6fb118d9aa73c12  guix-build-d405713197f8/output/arm-linux-gnueabihf/SHA256SUMS.part
 453f161f75428422ff2994842084b656bea000ffa3a81a72ba1b85aa79dfa8598  guix-build-d405713197f8/output/arm-linux-gnueabihf/bitcoin-d405713197f8-arm-linux-gnueabihf-debug.tar.gz
 56b0f2aed48d54474fc9fec7cca7f98861ebf17ea70ccf076da88669bde0f048b  guix-build-d405713197f8/output/arm-linux-gnueabihf/bitcoin-d405713197f8-arm-linux-gnueabihf.tar.gz
 6c03352c7fd3861745be88a6399e55d7e6953e0839b6e1f3bf14d9b2184396bc4  guix-build-d405713197f8/output/arm64-apple-darwin/SHA256SUMS.part
 7741191aefb3c8247156cf22d9cbb270287a9cb54e8965cc9a0af7d671b701593  guix-build-d405713197f8/output/arm64-apple-darwin/bitcoin-d405713197f8-arm64-apple-darwin-codesigning.tar.gz
 89cd2b53d46b60ec535abd161a33f07668137cd71f43c7508f5a749eb3a325e58  guix-build-d405713197f8/output/arm64-apple-darwin/bitcoin-d405713197f8-arm64-apple-darwin-unsigned.tar.gz
 9a6ae136a52c82d9bfd6a1844d4227d916e81a52de5a4fbfd5605d8400ff98b51  guix-build-d405713197f8/output/arm64-apple-darwin/bitcoin-d405713197f8-arm64-apple-darwin-unsigned.zip
105b6ca195d66b0917270a5485ecd8dd890931f506a0e22a37f3188bf53f1de141  guix-build-d405713197f8/output/dist-archive/bitcoin-d405713197f8.tar.gz
115d80313c02962d5ffdb19387f2b76b13f8491ea4bc59c03226f7e5db8565a564  guix-build-d405713197f8/output/powerpc64-linux-gnu/SHA256SUMS.part
120ffa66189ac95c054b656fee378bbc25fa0aa9ef438e6257c1f874a531e41276  guix-build-d405713197f8/output/powerpc64-linux-gnu/bitcoin-d405713197f8-powerpc64-linux-gnu-debug.tar.gz
132ae364a990314ac35f8884720d0be7ad019b00b05fc100da5a0fe176cb54f225  guix-build-d405713197f8/output/powerpc64-linux-gnu/bitcoin-d405713197f8-powerpc64-linux-gnu.tar.gz
14cd2806921d5f49f012619aef123340f9f30860065cc069f97c8a6638ea43c60e  guix-build-d405713197f8/output/riscv64-linux-gnu/SHA256SUMS.part
15478699e086ee81448646700189edb073d1fbb18ebcdfa8130aec3d0388dae730  guix-build-d405713197f8/output/riscv64-linux-gnu/bitcoin-d405713197f8-riscv64-linux-gnu-debug.tar.gz
1663fd4467e0930deaf5926c4364e74b668c676133ec2033c2c8c0a9515eadc96b  guix-build-d405713197f8/output/riscv64-linux-gnu/bitcoin-d405713197f8-riscv64-linux-gnu.tar.gz
1748716ce0608835b72cb3266ef8a4833c43ddb327f6dc608061c9d4e4e49b0415  guix-build-d405713197f8/output/x86_64-apple-darwin/SHA256SUMS.part
18352ba462d65eaa99f20211962f4334233989fe0541971ed22f354d9f39730035  guix-build-d405713197f8/output/x86_64-apple-darwin/bitcoin-d405713197f8-x86_64-apple-darwin-codesigning.tar.gz
19b5e766d45158875e6bd440ce2269fbd9fc4e3f9af0a30a45bf52f9776e8ceb95  guix-build-d405713197f8/output/x86_64-apple-darwin/bitcoin-d405713197f8-x86_64-apple-darwin-unsigned.tar.gz
20a0f1c6d39b8fcb95dd478746f0178efec8a3391485d8ee671bfa7d2f4da5e48c  guix-build-d405713197f8/output/x86_64-apple-darwin/bitcoin-d405713197f8-x86_64-apple-darwin-unsigned.zip
210edc13ecfc22723ebe7d974439813ee2f398978be128c3878a844410f791835e  guix-build-d405713197f8/output/x86_64-linux-gnu/SHA256SUMS.part
22dc4df3e11d224afefe79d549a270b7cd35659e422f7d067aae27cd4fa46fbcc4  guix-build-d405713197f8/output/x86_64-linux-gnu/bitcoin-d405713197f8-x86_64-linux-gnu-debug.tar.gz
23f5b0f63e03a2bd739563b658dd7a7bc89288dba83598430bd446f399a868da39  guix-build-d405713197f8/output/x86_64-linux-gnu/bitcoin-d405713197f8-x86_64-linux-gnu.tar.gz
2429c65fad74eadbaf8c989325f9dc3355a59e5962706027fe7ae9a9b7659d014d  guix-build-d405713197f8/output/x86_64-w64-mingw32/SHA256SUMS.part
259144e9892ade0c610f24ee414e42d183768582e527852bbc279530d0b7617e11  guix-build-d405713197f8/output/x86_64-w64-mingw32/bitcoin-d405713197f8-win64-codesigning.tar.gz
26d22d2e852e8f2f7fa412c8cadf4c291d270c00dd6796ad59874fc600b1fef76d  guix-build-d405713197f8/output/x86_64-w64-mingw32/bitcoin-d405713197f8-win64-debug.zip
27debb8f755925ef0b858c5073c37232a18f3747afce130f5806755486012ff949  guix-build-d405713197f8/output/x86_64-w64-mingw32/bitcoin-d405713197f8-win64-setup-unsigned.exe
28d2427c46747e5fecc8b831052d906a4cc6ff3af15697c094b52a128d36666985  guix-build-d405713197f8/output/x86_64-w64-mingw32/bitcoin-d405713197f8-win64-unsigned.zip

fanquake merged this on Feb 3, 2026

fanquake closed this on Feb 3, 2026

fanquake deleted the branch on Feb 3, 2026

Update secp256k1 subtree to latest master #34481

Reviews