test: fix intermittent failure in interface_zmq.py #34508

pull Hijanhv wants to merge 4 commits into bitcoin:master from Hijanhv:master changing 1 files +13 −1
  1. Hijanhv commented at 6:52 AM on February 5, 2026: none

    Add retry mechanism to handle race conditions where ZMQ notifications aren't immediately available after blockchain operations, preventing zmq.error.Again exceptions that cause test failures on slower systems.

    Fixes #34189

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. test: fix intermittent failure in interface_zmq.py
    Add retry mechanism to handle race conditions where ZMQ notifications
    aren't immediately available after blockchain operations, preventing
    zmq.error.Again exceptions that cause test failures on slower systems.
    
    Fixes #34189
    
    Signed-off-by: janhavi <janhavi@janhavis-MacBook-Air.local>
    7777691e06
  3. DrahtBot added the label Tests on Feb 5, 2026
  4. DrahtBot commented at 6:52 AM on February 5, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. Hijanhv commented at 8:04 AM on February 5, 2026: none

    @hebasto please approve the workflow !

  6. DrahtBot added the label CI failed on Feb 7, 2026
  7. DrahtBot commented at 9:08 AM on February 7, 2026: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. <sub>Task lint: https://github.com/bitcoin/bitcoin/actions/runs/21701878305/job/62834121764</sub> <sub>LLM reason (✨ experimental): Lint failure: ruff detected Python lint errors (trailing whitespace) in the code.</sub>

    <details><summary>Hints</summary>

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

  8. Merge branch 'bitcoin:master' into master b0052a96b4
  9. Merge branch 'bitcoin:master' into master dd1d7f643b
  10. maflcko commented at 9:18 AM on February 10, 2026: member
  11. Merge branch 'bitcoin:master' into master bd80f022a1
  12. maflcko commented at 8:24 AM on February 11, 2026: member

    I'll close this for now. Feel free to open a new pull, but make sure to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

    Also, you'll have to address the lint CI failure.

    There is no need to push new commits here without addressing any of the feedback.

  13. maflcko closed this on Feb 11, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-28 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me