ci: split vcpkg tools cache into restore/save #34559

1. 
   willcl-ark commented at 3:49 pm on February 11, 2026: member

   The vcpkg tools cache was using the combined actions/cache action, which by default saves on every run regardless of branch. Split it into the restore/save pattern used by the other caches, so that saves only happen on default branch pushes.

   This will have little impact in bitcoin/bitcoin (which uses few branches), but on forks, if you don’t update master branch frequently (which saves all caches), then all cache space will eventually be taken up by multiple vckpg tools caches, resulting in bad cache hit rates in all other jobs.

2. ci: Split vcpkg tools cache into restore/save

   The vcpkg tools cache was using the combined actions/cache action,
   which saves on every run regardless of branch. Split it into the
   restore/save pattern used by the other caches, so that saves only
   happen on default branch pushes.

   c413cf12c5
3. DrahtBot added the label Tests on Feb 11, 2026
4. 
   DrahtBot commented at 3:50 pm on February 11, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

5. 
   maflcko commented at 4:31 pm on February 11, 2026: member

   Seems similar to 32368cd3e9f359dd648496a25651a1993ba4e21c

   lgtm ACK c413cf12c5c6e688e71be84397a6e4fc75b5eaa4

   I don’t think the pull description is correct, because it re-used a constant cache-key, so once created, the cache will never again be written? Regardless of pull request or branch.

6. 
   willcl-ark commented at 4:57 pm on February 11, 2026: member

   Seems similar to 32368cd

   lgtm ACK c413cf1

   I don’t think the pull description is correct, because it re-used a constant cache-key, so once created, the cache will never again be written? Regardless of pull request or branch.

   actually, GHA saves one cache per branch (same name) as “unique” caches. these are not visible from other branches :( the only cache that is available to other branches is the default branch

7. 
   fanquake commented at 5:33 pm on February 11, 2026: member

   cc @m3dwards
8. fanquake merged this on Feb 13, 2026
9. fanquake closed this on Feb 13, 2026

   ---

10. 
    m3dwards commented at 1:44 pm on February 13, 2026: contributor

    I’ve just tested this on my fork and the windows native and windows native fuzz clash on cache key.

    I’m thinking however that this isn’t much of a problem as both jobs will share almost the same or exactly the same packages?

    0Failed to save: Unable to reserve cache with key windows-native-dll-vcpkg-tools-21986431344, another job may be creating this cache.
    

Contributors
willcl-ark DrahtBot maflcko fanquake m3dwards

Labels
Tests