Backports:
And the rc2 release process things
If any other files exist in the directory, we cannot assume the sharable files are exclusively for this wallet.
But if they are, this also cleans up other log.* files
Github-Pull: #34370
Rebased-From: 7475d134f6a3a6039ab6b9d39706ade47c764aa8
Github-Pull: #34370
Rebased-From: 60f529027c6eacbdc298fab50192f8c60d7082a1
Since we no longer delete the wallet directory, there's no need to vacate it
The moving only served to risk errors by crossing filesystem boundaries (which fs::rename can't handle)
Github-Pull: 34370
Rebased-From: cef01d0be5223e9d33efc897d7fbe5d0a08692c0
While 30.x+ keep backup files in walletdir, 29.x places them in the migrated wallet directory
Github-Pull: #34370
Rebased-From: 69a6b9b1152ba0bb3edab6d2a54509fd416b24c8
Github-Pull: #34370
Rebased-From: 65173944ed60df3b9cffca95932aed8720921478
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Stale ACK | willcl-ark |
If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
Needs a bump to the version in the release-notes.
Done
ACK bfaec08634ba4fe7f466070aab83fb33f7f5fc5e
These all look good to me. Only conflict looks like the MigrateLegacyToDescriptor signature.
Release notes look good too. Can re-review if you add 34671
Fixes https://github.com/bitcoin/bitcoin/issues/33982
Co-authored-by: Purple Ninja <129023353+ToRyVand@users.noreply.github.com>
Github-Pull: bitcoin/bitcoin#34671
Rebased-From: faa70ca7642bd653cbd2e544c17fa58d2672afa4