[28.x] backports and 28.4rc2 #34620

pull achow101 wants to merge 9 commits into bitcoin:28.x from achow101:28.4rc2-backports changing 13 files +105 −53
  1. achow101 commented at 1:17 am on February 19, 2026: member

    Backports:

    And the rc2 release process things

  2. Wallet/bdb: Safely and correctly list files only used by the single wallet
    If any other files exist in the directory, we cannot assume the sharable files are exclusively for this wallet.
    But if they are, this also cleans up other log.* files
    
    Github-Pull: #34370
    Rebased-From: 7475d134f6a3a6039ab6b9d39706ade47c764aa8
    29abedc97b
  3. Wallet/Migration: If loading the new watchonly or solvables wallet fails, log the correct wallet name in error message
    Github-Pull: #34370
    Rebased-From: 60f529027c6eacbdc298fab50192f8c60d7082a1
    619480bd78
  4. Wallet/Migration: Skip moving the backup file back and forth for no reason
    Since we no longer delete the wallet directory, there's no need to vacate it
    The moving only served to risk errors by crossing filesystem boundaries (which fs::rename can't handle)
    
    Github-Pull: 34370
    Rebased-From: cef01d0be5223e9d33efc897d7fbe5d0a08692c0
    6494072295
  5. Bugfix: Wallet/Migration: Move backup into wallet directory when migrating from non-directory
    While 30.x+ keep backup files in walletdir, 29.x places them in the migrated wallet directory
    
    Github-Pull: #34370
    Rebased-From: 69a6b9b1152ba0bb3edab6d2a54509fd416b24c8
    c5d9f75c4b
  6. QA: tool_wallet: Check that db.log is deleted with a lone legacy wallet, but not with a shared db environment
    Github-Pull: #34370
    Rebased-From: 65173944ed60df3b9cffca95932aed8720921478
    242b9ae3f3
  7. DrahtBot added the label Backport on Feb 19, 2026
  8. DrahtBot commented at 1:18 am on February 19, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Stale ACK willcl-ark

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  9. fanquake commented at 7:58 am on February 19, 2026: member
    Needs a bump to the version in the release-notes.
  10. fanquake added this to the milestone 28.4 on Feb 19, 2026
  11. achow101 force-pushed on Feb 19, 2026
  12. achow101 commented at 6:28 pm on February 19, 2026: member

    Needs a bump to the version in the release-notes.

    Done

  13. fanquake requested review from furszy on Feb 20, 2026
  14. fanquake commented at 10:10 am on February 26, 2026: member
    Can pull #34671 in here too.
  15. willcl-ark approved
  16. willcl-ark commented at 12:24 pm on February 26, 2026: member

    ACK bfaec08634ba4fe7f466070aab83fb33f7f5fc5e

    These all look good to me. Only conflict looks like the MigrateLegacyToDescriptor signature.

    Release notes look good too. Can re-review if you add 34671

  17. doc: Update Guix install for Debian/Ubuntu
    Fixes https://github.com/bitcoin/bitcoin/issues/33982
    
    Co-authored-by: Purple Ninja <129023353+ToRyVand@users.noreply.github.com>
    
    Github-Pull: bitcoin/bitcoin#34671
    Rebased-From: faa70ca7642bd653cbd2e544c17fa58d2672afa4
    931f12dcf7
  18. build: bump version to v28.4rc2 6cf3d8226d
  19. doc: Update release notes for v28.4rc2 46ff3698f8
  20. doc: update manpages for v28.4rc2 44e6dda745
  21. achow101 force-pushed on Feb 26, 2026
  22. achow101 commented at 6:04 pm on February 26, 2026: member
    Backported #34671


achow101 DrahtBot fanquake willcl-ark


furszy

Labels
Backport

Milestone
28.4


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-04 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me