script_assets_tests is a no-op on Windows CI #34670

issue hodlinator openend this issue on February 25, 2026
  1. hodlinator commented at 4:46 pm on February 25, 2026: contributor

    Since Windows has been switched to using Python scripts /.github/ci-windows-cross.py and /.github/ci-windows.py, DIR_UNIT_TEST_DATA is not set and the script_assets_tests unit test is a no-op. (Not 100% sure if the right conditions where met for it to be set before the switch to Python).

    Other platforms set up the environment, provided qa-assets exist:

    https://github.com/bitcoin/bitcoin/blob/7c8030143925b3ed8ca74b9e616dca20d36c4440/ci/test/03_test_script.sh#L57-L63

    Log displaying issue: https://github.com/bitcoin/bitcoin/actions/runs/22304756945/job/64521461506?pr=31507#step:8:1042 - excerpt:

    0./test/script_p2sh_tests.cpp(58): Leaving test suite "script_p2sh_tests"; testing time: 24751us
    1./test/script_assets_tests.cpp(30): Entering test suite "script_assets_tests"
    2./test/script_assets_tests.cpp(149): Entering test case "script_assets_test"
    3./test/script_assets_tests.cpp(156): warning: in "script_assets_tests/script_assets_test": Variable DIR_UNIT_TEST_DATA unset, skipping script_assets_test
    4Test case script_assets_tests/script_assets_test did not check any assertions
    5./test/script_assets_tests.cpp(149): Leaving test case "script_assets_test"; testing time: 2635us
    6./test/script_assets_tests.cpp(30): Leaving test suite "script_assets_tests"; testing time: 2666us
    7./test/scheduler_tests.cpp(16): Entering test suite "scheduler_tests"
    

    Maybe part of the bash script could be extracted to a shared Python module, not sure what the best solution is.

    Discovered here: #34666 (comment) cc @sedited @maflcko

  2. maflcko added the label Windows on Feb 26, 2026
  3. maflcko added the label Tests on Feb 26, 2026
  4. fanquake referenced this in commit 2eaf701bc0 on Mar 4, 2026
  5. fanquake closed this on Mar 4, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-09 12:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me