[29.x] Backports #34680

pull fanquake wants to merge 5 commits into bitcoin:29.x from fanquake:more_29_x_backports changing 5 files +24 −63
  1. fanquake commented at 10:11 am on February 26, 2026: member

    Backports:

  2. doc: fix broken bpftrace installation link
    The bpftrace project moved from iovisor/bpftrace to bpftrace/bpftraceand
    removed the separate INSTALL.md file. Installation instructionsare now
    in the README.md Quick Start section.
    
    Github-Pull: #34510
    Rebased-From: 42ee31e80c99bdb4d6affdc9dc22a0f3d5da7b59
    5910bd3b5d
  3. doc: Update Guix install for Debian/Ubuntu
    Fixes https://github.com/bitcoin/bitcoin/issues/33982
    
    Co-authored-by: Purple Ninja <129023353+ToRyVand@users.noreply.github.com>
    
    Github-Pull: #34671
    Rebased-From: faa70ca7642bd653cbd2e544c17fa58d2672afa4
    532afe909e
  4. wallet: rpc: manpage: fix example missing `fee_rate` argument
    The function signature for the `send` RPC is:
    ```
    send [{"address":amount,...},{"data":"hex"},...] ( conf_target "estimate_mode" fee_rate options version )
    ```
    
    The last example in the manpage is missing the `fee_rate` arg, but is trying to specify the `options` arg, by index.
    The parser confuses the intended `options` arg as the missing `fee_rate` arg.
    
    See:
    ```
    $ bitcoin-cli -rpcuser=doggman -rpcpassword=donkey -rpcport=18554 -regtest send '{"bcrt1qusm48zmlzwr32csxdw4ar7atw260h22c9ten9l": 0.1}' 1 economical '{"add_to_wallet": false, "inputs": [{"txid":"0b7e1a471dc948b7a6187936b16e6d7d9833629b2f9dd8a392eb89928f63aaad", "vout":0}]}'
    error code: -8
    error message:
    Cannot specify both conf_target and fee_rate. Please provide either a confirmation target in blocks for automatic fee estimation, or an explicit fee rate.
    ```
    vs
    ```
    $ bitcoin-cli -rpcuser=doggman -rpcpassword=donkey -rpcport=18554 -regtest send '{"bcrt1qusm48zmlzwr32csxdw4ar7atw260h22c9ten9l": 0.1}' 1 economical null '{"add_to_wallet": false, "inputs": [{"txid":"0b7e1a471dc948b7a6187936b16e6d7d9833629b2f9dd8a392eb89928f63aaad", "vout":0}]}'
    {
      "psbt": "cHNidP8BAHECAAAAAa2qY4+SieuSo9idL5tiM5h9bW6xNnkYprdIyR1HGn4LAAAAAAD9////AkR2DwQAAAAAFgAUpLDwJu+wFRHLQAgKAb0psk7UVd2AlpgAAAAAABYAFOQ3U4t/E4cVYgZrq9H7q3K0+6lYAAAAAAABAIUCAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA/////wQC4wMA/////wLIF6gEAAAAABYAFLMY1zihXrefAA0DA5nld4MCPjkrAAAAAAAAAAAmaiSqIant4vYcP3HR3v0/qZnfo2lTdVxpBol5mWK0i+vYNpdOjPkAAAAAAQEfyBeoBAAAAAAWABSzGNc4oV63nwANAwOZ5XeDAj45KwEIawJHMEQCIElTV4pbUrsPR9qHWcioowVv3QVWHizxwevfD0u/I8YyAiBCY3OzF81PSLM00h4ueQkehYuxDFZu7Jk51iejphKnnwEhA0VKdYVSyBpWoxBwTDOupB58Fi3mEBs+u+OOqEYVd2sZACICA98YLWyH7dBCfXVxe7woiLSTgV1mJN8Zc8KgZ77pVSg+GNBMeT5UAACAAQAAgAAAAIABAAAAbAAAAAAA",
      "txid": "625b71b314a6ac4f738634e29dc007cd5edc0427c1ae96ab706d06a62910cea2",
      "hex": "02000000000101adaa638f9289eb92a3d89d2f9b6233987d6d6eb1367918a6b748c91d471a7e0b0000000000fdffffff0244760f0400000000160014a4b0f026efb01511cb40080a01bd29b24ed455dd8096980000000000160014e437538b7f13871562066babd1fbab72b4fba9580247304402204953578a5b52bb0f47da8759c8a8a3056fdd05561e2cf1c1ebdf0f4bbf23c6320220426373b317cd4f48b334d21e2e79091e858bb10c566eec9939d627a3a612a79f012103454a758552c81a56a310704c33aea41e7c162de6101b3ebbe38ea84615776b1900000000",
      "complete": true
    }
    ```
    
    Github-Pull: #34561
    Rebased-From: 50cf6838e6aa51e0d712cbc1e13d686253bc8fe0
    98af76f875
  5. DrahtBot added the label Backport on Feb 26, 2026
  6. fanquake added this to the milestone 29.4 on Feb 26, 2026
  7. DrahtBot commented at 10:11 am on February 26, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK marcofleon

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  8. netif: fix compilation warning in QueryDefaultGatewayImpl()
    ```
    src/common/netif.cpp:137:51: error: comparison of integers of different signs: 'int64_t' (aka 'long') and 'unsigned long' [-Werror,-Wsign-compare]
      137 |         for (nlmsghdr* hdr = (nlmsghdr*)response; NLMSG_OK(hdr, recv_result); hdr = NLMSG_NEXT(hdr, recv_result)) {
          |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
    /usr/include/netlink/netlink.h:220:31: note: expanded from macro 'NLMSG_OK'
      220 | #define NLMSG_OK(_hdr, _len)            NL_ITEM_OK(_hdr, _len, NLMSG_HDRLEN, _NLMSG_LEN)
          |                                         ^                ~~~~  ~~~~~~~~~~~~
    /usr/include/netlink/netlink.h:203:10: note: expanded from macro 'NL_ITEM_OK'
      203 |         ((_len) >= _hlen && _LEN_M(_ptr) >= _hlen && _LEN_M(_ptr) <= (_len))
          |           ~~~~  ^  ~~~~~
    1 error generated.
    ```
    
    Happens on FreeBSD 15.0, with the default compiler (Clang 19).
    
    On FreeBSD 14, `/usr/include/netlink/netlink.h` contains:
    ```
     #define NLMSG_HDRLEN                    ((int)sizeof(struct nlmsghdr))
    ```
    
    On FreeBSD 15, `/usr/include/netlink/netlink.h` contains:
    ```
     #define NLMSG_HDRLEN                    (sizeof(struct nlmsghdr))
    ```
    
    Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
    
    Github-Pull: #34093
    Rebased-From: c1361fc42dd60606fcd6273cede1083cd88866a2
    490cd874a4
  9. doc: update release notes for v29.x 98ea6caed5
  10. fanquake force-pushed on Feb 27, 2026
  11. fanquake marked this as ready for review on Mar 9, 2026
  12. fanquake requested review from marcofleon on Mar 9, 2026
  13. marcofleon approved
  14. marcofleon commented at 4:35 pm on March 9, 2026: contributor
    ACK 98ea6caed5259c279f7f4794fbafb67ab078e9ae
  15. fanquake merged this on Mar 9, 2026
  16. fanquake closed this on Mar 9, 2026

  17. fanquake deleted the branch on Mar 9, 2026


fanquake DrahtBot marcofleon

Labels
Backport

Milestone
29.4


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-24 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me