test: replace bare asserts with assertion helpers in wallet_bumpfee.py #34739

1. 
   Bortlesboat commented at 2:11 am on March 5, 2026: none

   Replace 6 bare assert statements in test/functional/wallet_bumpfee.py with test framework helpers (assert_greater_than, assert_equal).

   Bare asserts produce unhelpful AssertionError with no context on failure. The helpers print actual vs expected values.

   Changes:

   • assert bumped_tx["fee"] > -rbftx["fee"] → assert_greater_than
   • assert bumped_psbt["fee"] > -rbftx["fee"] → assert_greater_than
   • assert len(oldwtx["walletconflicts"]) > 0 → assert_greater_than
   • assert len(bumpedwtx["details"]) == 1 → assert_equal
   • assert bumpedwtx["details"][0]["address"] == new_address → assert_equal
   • assert rbf_node.getbalance() < 49 → assert_greater_than(49, ...)

   No new imports needed — all helpers already imported. Each replacement preserves the exact same logical condition.

   Part of #23119.

2. test: replace bare asserts with assertion helpers in wallet_bumpfee.py

   Replace 6 bare assert statements with test framework helpers
   (assert_greater_than, assert_equal) to produce more informative
   error messages on failure.
   
   Part of #23119.

   73bd855c1b
3. DrahtBot added the label Tests on Mar 5, 2026
4. 
   DrahtBot commented at 2:11 am on March 5, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

5. 
   maflcko commented at 6:26 am on March 5, 2026: member

   lgtm ACK 73bd855c1b430d3630ca7b2de283a9a8a35f44d9
6. Bortlesboat closed this on Mar 6, 2026

   ---

Contributors
Bortlesboat DrahtBot maflcko

Labels
Tests