test: replace bare asserts with assertion helpers in wallet_bumpfee.py #34739

pull Bortlesboat wants to merge 1 commits into bitcoin:master from Bortlesboat:test-replace-bare-asserts-wallet-bumpfee changing 1 files +6 −6
  1. Bortlesboat commented at 2:11 AM on March 5, 2026: none

    Replace 6 bare assert statements in test/functional/wallet_bumpfee.py with test framework helpers (assert_greater_than, assert_equal).

    Bare asserts produce unhelpful AssertionError with no context on failure. The helpers print actual vs expected values.

    Changes:

    • assert bumped_tx["fee"] > -rbftx["fee"]assert_greater_than
    • assert bumped_psbt["fee"] > -rbftx["fee"]assert_greater_than
    • assert len(oldwtx["walletconflicts"]) > 0assert_greater_than
    • assert len(bumpedwtx["details"]) == 1assert_equal
    • assert bumpedwtx["details"][0]["address"] == new_addressassert_equal
    • assert rbf_node.getbalance() < 49assert_greater_than(49, ...)

    No new imports needed — all helpers already imported. Each replacement preserves the exact same logical condition.

    Part of #23119.

  2. test: replace bare asserts with assertion helpers in wallet_bumpfee.py
    Replace 6 bare assert statements with test framework helpers
    (assert_greater_than, assert_equal) to produce more informative
    error messages on failure.
    
    Part of #23119.
    73bd855c1b
  3. DrahtBot added the label Tests on Mar 5, 2026
  4. DrahtBot commented at 2:11 AM on March 5, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. maflcko commented at 6:26 AM on March 5, 2026: member

    lgtm ACK 73bd855c1b430d3630ca7b2de283a9a8a35f44d9

  6. Bortlesboat closed this on Mar 6, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me