doc: Update asmap-data repository rule for file inclusion #34751

pull fjahr wants to merge 1 commits into bitcoin:master from fjahr:2026-03-asmap-rule changing 1 files +3 −3
  1. fjahr commented at 9:23 am on March 6, 2026: contributor

    This updates the decision rule for file inclusion in the asmap-data repository after a collaborative run following discussion in the latest run: https://github.com/bitcoin-core/asmap-data/issues/44

    The change is small but does a few things:

    • No minimum number of participants recommended anymore
    • Minimum number of matches set to 5 (which was previously the number of recommended min participants)
    • The result that is taken does not need to see a match between the majority of participants, it only needs to have the most matches
    • Participants that saw a match should sign for it

    I also thought about adding an explicit tie-breaker if there are two results with the same number of matches but since both results are equally valid I think it won’t be needed (?)

  2. DrahtBot added the label Docs on Mar 6, 2026
  3. DrahtBot commented at 9:24 am on March 6, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hodlinator, luisschwab

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  4. doc: Update asmap-data repository rule for file inclusion 8bc62ce173
  5. fjahr force-pushed on Mar 6, 2026
  6. DrahtBot added the label CI failed on Mar 6, 2026
  7. fanquake commented at 9:54 am on March 6, 2026: member
    Could just combine this with #34696, with the new data? Seems like we want both to land for v31.
  8. fjahr commented at 10:32 am on March 6, 2026: contributor

    Could just combine this with #34696, with the new data? Seems like we want both to land for v31.

    Ok, I will do that once we have processed and merged the new data so I can include it in #34696. Leaving this open for now in case there is feedback on wording etc. in the meantime.

  9. DrahtBot removed the label CI failed on Mar 6, 2026
  10. in doc/asmap-data.md:1 in 8bc62ce173


    hodlinator commented at 11:02 am on March 6, 2026:

    @fjahr bringing up sock-puppets1 made me think of sybil-resistance wrt deciding on the hash reported by most participants. Rather same account with many machines, one could create multiple accounts and duplicate the data from one machine (possibly after manipulating it to skew bucketing?).

    We probably should not be too concerned about that now, instead handling it if/when it happens.


    fjahr commented at 11:26 am on March 6, 2026:

    We probably should not be too concerned about that now, instead handling it if/when it happens.

    Right, we have the same problem with code review ACKs and afaik we don’t have any explicit rules on that either. We just give the regular reviewers more weight than a unknown drive-by ACK. I guess the one difference is a unknown reviewer can still make good review comments and show they have put in the work which isn’t possible with the asmap run.


    fanquake commented at 11:31 am on March 6, 2026:

    a unknown reviewer

    It’s also the case that, at least initially, there wasn’t so much cross-over from the asmap participants, and regular bitcoin-core contributors. Although hopefully that will never be an issue going forward, as contributors to this repo, should also be participating in asmap, the same as guix.sigs.

  11. hodlinator approved
  12. hodlinator commented at 11:10 am on March 6, 2026: contributor
    ACK 8bc62ce173dd492ca862a692a88d526d406e0eb3
  13. fanquake added this to the milestone 31.0 on Mar 6, 2026
  14. luisschwab commented at 3:05 pm on March 6, 2026: contributor
    ACK 8bc62ce173dd492ca862a692a88d526d406e0eb3

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-09 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me