guix: introduce –exclude parameter to guix-clean #34790

pull kevkevinpal wants to merge 1 commits into bitcoin:master from kevkevinpal:guixCleanExclude changing 1 files +54 −8
  1. kevkevinpal commented at 3:22 pm on March 10, 2026: contributor

    Summary

    This is motivated by #34776 (comment) and a follow-up to #34776.

    The motivation is that when a user runs contrib/guix/guix-clean it will clean the whole directory or nothing leading the user to have to manually clear out these files. It would be useful to be able to exclude certain files.

    It adds the --exclude and --help/-h parameters to contrib/guix/guix-clean

    Right now, when a user runs that script, it will delete everything. It makes sense to allow the user to exclude any files or directories from being removed.


    Help text

    Screenshot 2026-03-10 at 10 15 08 AM

    Multiple excludes

    Screenshot 2026-03-10 at 10 15 30 AM

    Unknown option

    Screenshot 2026-03-10 at 10 19 41 AM

    Exclude with –force

    Screenshot 2026-03-10 at 10 19 53 AM

  2. DrahtBot added the label Build system on Mar 10, 2026
  3. DrahtBot commented at 3:22 pm on March 10, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    No conflicts as of last run.

  4. fanquake commented at 10:21 am on March 12, 2026: member

    Concept ~0. Not sure how much further we need to complicate this script.

    This is a follow-up to https://github.com/kevkevinpal/bitcoin/pull/new/guixCleanExclude

    Can you fix the PR description.

  5. sedited commented at 10:25 am on March 12, 2026: contributor
    I’m not sure about this change either. Listing the files as done now seems good enough to me, and the changes proposed here mostly seem to complicate things.
  6. DrahtBot added the label Needs rebase on Mar 12, 2026
  7. kevkevinpal force-pushed on Mar 12, 2026
  8. guix: guix-clean allow to exclude files or directories b752f1242c
  9. kevkevinpal force-pushed on Mar 12, 2026
  10. kevkevinpal commented at 12:59 pm on March 12, 2026: contributor

    Thank you for the review!

    Concept ~0. Not sure how much further we need to complicate this script.

    Part of the reason I thought this might make sense and not add too much complication is that exclude_flags already exists in the script; this only allows the user to add to it.

    Can you fix the PR description.

    Fixed!

    I’m not sure about this change either. Listing the files as done now seems good enough to me, and the changes proposed here mostly seem to complicate things.

    Understood, if others feel this is unneeded, I can close. I do feel this adds useful functionality for this script, so users don’t have to manually remove files if they don’t want one deleted.

  11. DrahtBot removed the label Needs rebase on Mar 12, 2026
  12. fanquake commented at 7:02 am on March 23, 2026: member
    Lets close this for now. Can always return in future.
  13. fanquake closed this on Mar 23, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-30 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me