depends: Remove no longer necessary `dsymutil`

hebasto commented at 1:58 pm on March 18, 2026: member

I can’t see where dsymutil is used. For example, a shared library under LTO builds fine:

0cmake -B build --toolchain depends/arm64-apple-darwin/toolchain.cmake -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=ON -DBUILD_KERNEL_LIB=ON -DBUILD_SHARED_LIBS=ON
1cmake --build build -t libbitcoinkernel

depends: Remove no longer necessary `dsymutil` 578525d31d

hebasto added the label Build system on Mar 18, 2026

DrahtBot commented at 1:58 pm on March 18, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake

If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

DrahtBot added the label CI failed on Mar 18, 2026

DrahtBot removed the label CI failed on Mar 18, 2026

hebasto commented at 4:10 pm on March 18, 2026: member

My Guix build:

 0x86_64
 140abadf01ada6be96fae0b2db930a8d3bbd370e039d09c8fbdda49eb659456bc  guix-build-578525d31d47/output/aarch64-linux-gnu/SHA256SUMS.part
 253085906ab5f0cb2333a58d3c5b584785821091ad72980996f7de7f8a671fa86  guix-build-578525d31d47/output/aarch64-linux-gnu/bitcoin-578525d31d47-aarch64-linux-gnu-debug.tar.gz
 3d73c1d68801efab1fc8594d062cb2550f1841985e66aa474e86647da703a4c79  guix-build-578525d31d47/output/aarch64-linux-gnu/bitcoin-578525d31d47-aarch64-linux-gnu.tar.gz
 4c7e45dfffb78842b4236e37d1494d5b2d209aa1f224cedb68e35437a29bb9af5  guix-build-578525d31d47/output/arm-linux-gnueabihf/SHA256SUMS.part
 58650690774c1d32377d16c730ad584648642ef4de94a42a208ecc0e425b8495d  guix-build-578525d31d47/output/arm-linux-gnueabihf/bitcoin-578525d31d47-arm-linux-gnueabihf-debug.tar.gz
 6ac89a5fba93072c4d4aebdc3c361c41e572eec0af078038b4b7ae79502bc1987  guix-build-578525d31d47/output/arm-linux-gnueabihf/bitcoin-578525d31d47-arm-linux-gnueabihf.tar.gz
 7ac20617d5fe1d03655955c1e5491b667ff3c1b57d89f4c29b4bb8bb0637c1e7e  guix-build-578525d31d47/output/arm64-apple-darwin/SHA256SUMS.part
 8370ce88c9275ecc3c9a98e6cded28f06dc4f0ee4198977e86d36931e23b16d61  guix-build-578525d31d47/output/arm64-apple-darwin/bitcoin-578525d31d47-arm64-apple-darwin-codesigning.tar.gz
 9bbd30b84246182d56f72704c55e58d8d72b417eea4c6f101b00f097e1fb757c8  guix-build-578525d31d47/output/arm64-apple-darwin/bitcoin-578525d31d47-arm64-apple-darwin-unsigned.tar.gz
100bf99d2508e92261fef6319e3af08ce809dcd0977149351b283b10e9a8a7650e  guix-build-578525d31d47/output/arm64-apple-darwin/bitcoin-578525d31d47-arm64-apple-darwin-unsigned.zip
11e22220b3450d1557a36004e5d3919535f0c58d85cc2ba9ea3de40ba6c8c78919  guix-build-578525d31d47/output/dist-archive/bitcoin-578525d31d47.tar.gz
12d820aa7060ad693086e5bc23ab82044324a9ab92da78cbf1f48688336a4d364d  guix-build-578525d31d47/output/powerpc64-linux-gnu/SHA256SUMS.part
1390a284743b2bf069bfb0198a9af3b721a7a343af921fefa4813e132e1ac7633d  guix-build-578525d31d47/output/powerpc64-linux-gnu/bitcoin-578525d31d47-powerpc64-linux-gnu-debug.tar.gz
146e1af4277944318d1f553c0e5f8378f2f0048c0a3f02c9345c654e163f4ac393  guix-build-578525d31d47/output/powerpc64-linux-gnu/bitcoin-578525d31d47-powerpc64-linux-gnu.tar.gz
15ac6b889e65b917c187e23a61bc06846a325af9a9cccd5bd6864add4975ce4af6  guix-build-578525d31d47/output/riscv64-linux-gnu/SHA256SUMS.part
16f3d49f8d27aed407d3c8072842e83cd9ae2506400c04930235b84eace2a8b3f3  guix-build-578525d31d47/output/riscv64-linux-gnu/bitcoin-578525d31d47-riscv64-linux-gnu-debug.tar.gz
17d15de56fecb10e4c7386ba7c82231515c57775e9d904725305bf16a04a64a49c  guix-build-578525d31d47/output/riscv64-linux-gnu/bitcoin-578525d31d47-riscv64-linux-gnu.tar.gz
18906dd07434a7fc57732fb0944083a58b2051c17420626f54a1334bcdf1fe016f  guix-build-578525d31d47/output/x86_64-apple-darwin/SHA256SUMS.part
19db4794604b0c876df6bd7834a0604dc99ea08d247749e88cc066a0de3f3dbc77  guix-build-578525d31d47/output/x86_64-apple-darwin/bitcoin-578525d31d47-x86_64-apple-darwin-codesigning.tar.gz
2065e47aa169ac794b8fdaef6e9b41e268ae1eb6606306f982326dcd5c2a8b02e5  guix-build-578525d31d47/output/x86_64-apple-darwin/bitcoin-578525d31d47-x86_64-apple-darwin-unsigned.tar.gz
21f2647b4c81183dcbb15bb7f5d3f87021d088806ca3d2e1a1fa39838dc2d93f7f  guix-build-578525d31d47/output/x86_64-apple-darwin/bitcoin-578525d31d47-x86_64-apple-darwin-unsigned.zip
227d450a29a9034b7f7cc679fd21d8895bfb03b65f3d9717fb635ae28300bfd98e  guix-build-578525d31d47/output/x86_64-linux-gnu/SHA256SUMS.part
232bd0ae0e8b1204742a4db5a755581aab15cffb619ad986b7d3bc3e2ccf7d5478  guix-build-578525d31d47/output/x86_64-linux-gnu/bitcoin-578525d31d47-x86_64-linux-gnu-debug.tar.gz
24aaa273d034f7514dc01cc2cf9889b296aa34f533493d5b4ac93bbeb27d0c480c  guix-build-578525d31d47/output/x86_64-linux-gnu/bitcoin-578525d31d47-x86_64-linux-gnu.tar.gz
25cbc9260d87c46d22eb58c7ca52d7f0e0cd7f976842288fe3dab1e1de108114ad  guix-build-578525d31d47/output/x86_64-w64-mingw32/SHA256SUMS.part
267633bd60bb38fa419b1f3dcd3255262d66e7242037778a9ea92eb30108e64458  guix-build-578525d31d47/output/x86_64-w64-mingw32/bitcoin-578525d31d47-win64-codesigning.tar.gz
274f2eb54460790336c96445e860702aee7e6f076160a1634e145dd85977d75d07  guix-build-578525d31d47/output/x86_64-w64-mingw32/bitcoin-578525d31d47-win64-debug.zip
2850c343eb5df751be002f5dacc71ecd2282d9295f6365a86e8b8a21d06358f2a0  guix-build-578525d31d47/output/x86_64-w64-mingw32/bitcoin-578525d31d47-win64-setup-unsigned.exe
29b03687ca5a8be6c97bb7b7734a41204d6546251b1d3107d7b05de016d04ca04e  guix-build-578525d31d47/output/x86_64-w64-mingw32/bitcoin-578525d31d47-win64-unsigned.zip

theuni commented at 10:11 pm on March 18, 2026: member

autotools used to check for dsymutil so we set it in our config.site. Presumably it exported it for usage by clang.

But it seems that wasn’t ported to CMake and nothing has broken since. And it seems that nothing is using the variables we’re setting. So I’m inclined to agree that it’s unnecessary.

I suspect this was required by cctools when we were still hacking together our own toolchain.

fanquake commented at 8:47 am on March 19, 2026: member

Concept ACK

hebasto marked this as ready for review on Mar 19, 2026

hebasto commented at 10:49 am on March 19, 2026: member

Undrafted.

fanquake commented at 3:19 am on March 23, 2026: member

Guix Build (x86_64):

 040abadf01ada6be96fae0b2db930a8d3bbd370e039d09c8fbdda49eb659456bc  guix-build-578525d31d47/output/aarch64-linux-gnu/SHA256SUMS.part
 153085906ab5f0cb2333a58d3c5b584785821091ad72980996f7de7f8a671fa86  guix-build-578525d31d47/output/aarch64-linux-gnu/bitcoin-578525d31d47-aarch64-linux-gnu-debug.tar.gz
 2d73c1d68801efab1fc8594d062cb2550f1841985e66aa474e86647da703a4c79  guix-build-578525d31d47/output/aarch64-linux-gnu/bitcoin-578525d31d47-aarch64-linux-gnu.tar.gz
 3c7e45dfffb78842b4236e37d1494d5b2d209aa1f224cedb68e35437a29bb9af5  guix-build-578525d31d47/output/arm-linux-gnueabihf/SHA256SUMS.part
 48650690774c1d32377d16c730ad584648642ef4de94a42a208ecc0e425b8495d  guix-build-578525d31d47/output/arm-linux-gnueabihf/bitcoin-578525d31d47-arm-linux-gnueabihf-debug.tar.gz
 5ac89a5fba93072c4d4aebdc3c361c41e572eec0af078038b4b7ae79502bc1987  guix-build-578525d31d47/output/arm-linux-gnueabihf/bitcoin-578525d31d47-arm-linux-gnueabihf.tar.gz
 6ac20617d5fe1d03655955c1e5491b667ff3c1b57d89f4c29b4bb8bb0637c1e7e  guix-build-578525d31d47/output/arm64-apple-darwin/SHA256SUMS.part
 7370ce88c9275ecc3c9a98e6cded28f06dc4f0ee4198977e86d36931e23b16d61  guix-build-578525d31d47/output/arm64-apple-darwin/bitcoin-578525d31d47-arm64-apple-darwin-codesigning.tar.gz
 8bbd30b84246182d56f72704c55e58d8d72b417eea4c6f101b00f097e1fb757c8  guix-build-578525d31d47/output/arm64-apple-darwin/bitcoin-578525d31d47-arm64-apple-darwin-unsigned.tar.gz
 90bf99d2508e92261fef6319e3af08ce809dcd0977149351b283b10e9a8a7650e  guix-build-578525d31d47/output/arm64-apple-darwin/bitcoin-578525d31d47-arm64-apple-darwin-unsigned.zip
10e22220b3450d1557a36004e5d3919535f0c58d85cc2ba9ea3de40ba6c8c78919  guix-build-578525d31d47/output/dist-archive/bitcoin-578525d31d47.tar.gz
11d820aa7060ad693086e5bc23ab82044324a9ab92da78cbf1f48688336a4d364d  guix-build-578525d31d47/output/powerpc64-linux-gnu/SHA256SUMS.part
1290a284743b2bf069bfb0198a9af3b721a7a343af921fefa4813e132e1ac7633d  guix-build-578525d31d47/output/powerpc64-linux-gnu/bitcoin-578525d31d47-powerpc64-linux-gnu-debug.tar.gz
136e1af4277944318d1f553c0e5f8378f2f0048c0a3f02c9345c654e163f4ac393  guix-build-578525d31d47/output/powerpc64-linux-gnu/bitcoin-578525d31d47-powerpc64-linux-gnu.tar.gz
14ac6b889e65b917c187e23a61bc06846a325af9a9cccd5bd6864add4975ce4af6  guix-build-578525d31d47/output/riscv64-linux-gnu/SHA256SUMS.part
15f3d49f8d27aed407d3c8072842e83cd9ae2506400c04930235b84eace2a8b3f3  guix-build-578525d31d47/output/riscv64-linux-gnu/bitcoin-578525d31d47-riscv64-linux-gnu-debug.tar.gz
16d15de56fecb10e4c7386ba7c82231515c57775e9d904725305bf16a04a64a49c  guix-build-578525d31d47/output/riscv64-linux-gnu/bitcoin-578525d31d47-riscv64-linux-gnu.tar.gz
17906dd07434a7fc57732fb0944083a58b2051c17420626f54a1334bcdf1fe016f  guix-build-578525d31d47/output/x86_64-apple-darwin/SHA256SUMS.part
18db4794604b0c876df6bd7834a0604dc99ea08d247749e88cc066a0de3f3dbc77  guix-build-578525d31d47/output/x86_64-apple-darwin/bitcoin-578525d31d47-x86_64-apple-darwin-codesigning.tar.gz
1965e47aa169ac794b8fdaef6e9b41e268ae1eb6606306f982326dcd5c2a8b02e5  guix-build-578525d31d47/output/x86_64-apple-darwin/bitcoin-578525d31d47-x86_64-apple-darwin-unsigned.tar.gz
20f2647b4c81183dcbb15bb7f5d3f87021d088806ca3d2e1a1fa39838dc2d93f7f  guix-build-578525d31d47/output/x86_64-apple-darwin/bitcoin-578525d31d47-x86_64-apple-darwin-unsigned.zip
217d450a29a9034b7f7cc679fd21d8895bfb03b65f3d9717fb635ae28300bfd98e  guix-build-578525d31d47/output/x86_64-linux-gnu/SHA256SUMS.part
222bd0ae0e8b1204742a4db5a755581aab15cffb619ad986b7d3bc3e2ccf7d5478  guix-build-578525d31d47/output/x86_64-linux-gnu/bitcoin-578525d31d47-x86_64-linux-gnu-debug.tar.gz
23aaa273d034f7514dc01cc2cf9889b296aa34f533493d5b4ac93bbeb27d0c480c  guix-build-578525d31d47/output/x86_64-linux-gnu/bitcoin-578525d31d47-x86_64-linux-gnu.tar.gz
24cbc9260d87c46d22eb58c7ca52d7f0e0cd7f976842288fe3dab1e1de108114ad  guix-build-578525d31d47/output/x86_64-w64-mingw32/SHA256SUMS.part
257633bd60bb38fa419b1f3dcd3255262d66e7242037778a9ea92eb30108e64458  guix-build-578525d31d47/output/x86_64-w64-mingw32/bitcoin-578525d31d47-win64-codesigning.tar.gz
264f2eb54460790336c96445e860702aee7e6f076160a1634e145dd85977d75d07  guix-build-578525d31d47/output/x86_64-w64-mingw32/bitcoin-578525d31d47-win64-debug.zip
2750c343eb5df751be002f5dacc71ecd2282d9295f6365a86e8b8a21d06358f2a0  guix-build-578525d31d47/output/x86_64-w64-mingw32/bitcoin-578525d31d47-win64-setup-unsigned.exe
28b03687ca5a8be6c97bb7b7734a41204d6546251b1d3107d7b05de016d04ca04e  guix-build-578525d31d47/output/x86_64-w64-mingw32/bitcoin-578525d31d47-win64-unsigned.zip

fanquake commented at 3:24 am on March 23, 2026: member

ACK 578525d31d47bad878f8609a04258920b1deab42

But it seems that wasn’t ported to CMake

Yea. Might end up backporting this as cleanup as well.

fanquake merged this on Mar 23, 2026

fanquake closed this on Mar 23, 2026

fanquake referenced this in commit 051afe9e1a on Mar 23, 2026

fanquake commented at 4:12 am on March 23, 2026: member

Backported to 31.x in #34800.

hebasto deleted the branch on Mar 23, 2026

depends: Remove no longer necessary dsymutil #34850

Reviews

depends: Remove no longer necessary `dsymutil` #34850