test: Fix intermittent issue in feature_assumeutxo.py #34852

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2603-test-fix-int changing 2 files +6 −18
  1. maflcko commented at 3:13 pm on March 18, 2026: member

    The test has many issues:

    Fix all issues by using dumb_sync_blocks and avoid the two restarts.

    Fixes #33635

    Diff to test:

     0diff --git a/src/util/tokenpipe.cpp b/src/util/tokenpipe.cpp
     1index c982fa6fc4..1dc12ea1d5 100644
     2--- a/src/util/tokenpipe.cpp
     3+++ b/src/util/tokenpipe.cpp
     4@@ -4,2 +4,3 @@
     5 #include <util/tokenpipe.h>
     6+#include <util/time.h>
     7 
     8@@ -60,2 +61,3 @@ int TokenPipeEnd::TokenRead()
     9         ssize_t result = read(m_fd, &token, 1);
    10+        UninterruptibleSleep(999ms);
    11         if (result < 0) {
    

    On master: Test fails On this pull: Test passes

  2. test: Fix intermittent issue in feature_assumeutxo.py 99996f6c06
  3. DrahtBot added the label Tests on Mar 18, 2026
  4. DrahtBot commented at 3:14 pm on March 18, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK sedited, fjahr

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  5. test: [refactor] Use verbosity=0 named arg
    This is less confusing than the verbose=0 alias.
    faf71d6cb4
  6. DrahtBot added the label CI failed on Mar 18, 2026
  7. sedited approved
  8. sedited commented at 4:04 pm on March 18, 2026: contributor
    ACK faf71d6cb49b8a668c417d80bc56277f30cbf2e1
  9. DrahtBot removed the label CI failed on Mar 18, 2026
  10. fjahr commented at 10:29 pm on March 18, 2026: contributor
    Code review ACK faf71d6cb49b8a668c417d80bc56277f30cbf2e1
  11. fanquake merged this on Mar 19, 2026
  12. fanquake closed this on Mar 19, 2026

  13. fanquake referenced this in commit 8379f005da on Mar 19, 2026
  14. fanquake referenced this in commit 068951211c on Mar 19, 2026
  15. fanquake commented at 6:08 am on March 19, 2026: member
    Backported to 31.x in #34800.
  16. maflcko deleted the branch on Mar 19, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-05 12:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me