Backports:
[30.x] Backports #34856
pull fanquake wants to merge 6 commits into bitcoin:30.x from fanquake:more_30_x_backports changing 9 files +70 −5-
fanquake commented at 6:50 am on March 19, 2026: member
-
fde84b822e
cmake: Migrate away from deprecated SQLite3 target
CMake version 4.3 deprecated the imported target `Sqlite::Sqlite3`. Use the preferred name `Sqlite3::Sqlite3` instead and provide an alias for older versions of CMake. Also define the same alias when using vcpkg. Github-Pull: #34848 Rebased-From: 498b6eb6b5e8aceb372d3097df2715d9c7fc416b
-
fanquake added this to the milestone 30.3 on Mar 19, 2026
-
DrahtBot added the label Backport on Mar 19, 2026
-
DrahtBot commented at 6:50 am on March 19, 2026: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK marcofleon If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
-
72d2b85414
tests: applied PYTHON_GIL to the env for every test
Github-Pull: #34869 Rebased-From: b14f2c76a1f6b41835c134584c82c45704c4cce0
-
fanquake force-pushed on Mar 20, 2026
-
f05988aa05
wallet: fix amount computed as boolean in coin selection
The comparison is evaluated before the assignment, so total_amount ends up holding a boolean instead of the actual amount: total_amount = (a - b < c) which is not what we want here. This has been working by accident. Github-Pull: #34888 Rebased-From: 0026b330c4abbbbdb96e4f0c4d380d70d8e592ab
-
fanquake force-pushed on Mar 24, 2026
-
84c2f003b3
wallet: feebumper, fix crash when combined bump fee is unavailable
When a large cluster of unconfirmed transactions exceeds the limit, calculateCombinedBumpFee() returns std::nullopt. Previously, we continued executing and the optional value was accessed unconditionally, leading to a std::bad_optional_access exception. Fix this by returning early when the returned bumped fee is null. Note: This is a crash for the GUI, and an uncaught exception for the RPC bumpfee and psbtbumpfee. Github-Pull: #34870 Rebased-From: 6072a2a6a1fdde8444e3515f0d201de3fb3923a1
-
fanquake force-pushed on Mar 24, 2026
-
6bba04ba73
depends, qt: Fix build on aarch64 macOS 26.4
Github-Pull: #34956 Rebased-From: 3aeccb7d739c7e9a82c95fbc8f5647ea85a79635
-
doc: update release notes for v30.x 75d707b307
-
fanquake force-pushed on Apr 1, 2026
-
fanquake marked this as ready for review on Apr 6, 2026
-
fanquake requested review from marcofleon on Apr 6, 2026
-
marcofleon commented at 12:37 pm on April 7, 2026: contributorYou have #34832 in the pr description, but I’m not seeing the actual commit included?
-
marcofleon approved
-
marcofleon commented at 1:52 pm on April 7, 2026: contributorlgtm ACK 75d707b307f69a7b153b24e66b9906611faa4645
-
fanquake merged this on Apr 7, 2026
-
fanquake closed this on Apr 7, 2026
-
fanquake deleted the branch on Apr 7, 2026
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-11 09:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-11 09:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me