On Windows, the winerror.h header defines WAIT_TIMEOUT as a macro.
This introduces a fragile dependency on header inclusion order: if Windows headers happen to be included before using WAIT_TIMEOUT, the preprocessor expands it into a numeric literal, causing syntax errors.
Rename the variable to TEST_WAIT_TIMEOUT to remove this fragility and avoid the collision entirely.
Split from #34448.
Similar to #34454.
On Windows, the `winerror.h` header defines `WAIT_TIMEOUT` as a macro.
This introduces a fragile dependency on header inclusion order: if
Windows headers happen to be included before using `WAIT_TIMEOUT`, the
preprocessor expands it into a numeric literal, causing syntax errors.
Rename the variable to `TEST_WAIT_TIMEOUT` to remove this fragility and
avoid the collision entirely.
-BEGIN VERIFY SCRIPT-
sed -i 's/\<WAIT_TIMEOUT\>/TEST_WAIT_TIMEOUT/g' $(git grep -l 'WAIT_TIMEOUT' ./src/)
-END VERIFY SCRIPT-
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | w0xlt |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
ACK 658e68f95b19aee765da1990c004805810d48c34
Reference: https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499-