guix: Remove make-lld-wrapper #34877

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260320-no-lld-wrapper changing 1 files +0 −1
  1. hebasto commented at 11:48 am on March 20, 2026: member

    The LLD wrapper aims to add any missing -rpath flags. However, this is only required for native binaries, and is already handled by the native toolchain (currently gcc-toolchain-14).

    Based on my testing, it wasn’t necessary in the original #21778.

    My Guix build for macOS targets (on both x86_64 and aarch64 platforms):

    0ebb020db55591ed1b85b5d64145a658032879b8641cde43c259cae3e6abc19db  guix-build-b849d6c51815/output/arm64-apple-darwin/SHA256SUMS.part
    1798596beec8e473519d8b512cd6d178d1bce9e9a9e89d955844df0c89853be41  guix-build-b849d6c51815/output/arm64-apple-darwin/bitcoin-b849d6c51815-arm64-apple-darwin-codesigning.tar.gz
    2efe3cc64e3d5ca76fa96d1faa39d7411989feb7fb285eed212675bd7e9309552  guix-build-b849d6c51815/output/arm64-apple-darwin/bitcoin-b849d6c51815-arm64-apple-darwin-unsigned.tar.gz
    39f468c9c005d0a13a2a3b876a5f9a92770d08a63b8e19e1d76f123947773fd77  guix-build-b849d6c51815/output/arm64-apple-darwin/bitcoin-b849d6c51815-arm64-apple-darwin-unsigned.zip
    4e81d27c3e74ea43ce812f392af50400bd6988b8fc6cee4c5e61d225724cc0552  guix-build-b849d6c51815/output/dist-archive/bitcoin-b849d6c51815.tar.gz
    58b20cd54087c9a0651e938ffb61d60e18cd90219928e168e7f96c1c3756bb751  guix-build-b849d6c51815/output/x86_64-apple-darwin/SHA256SUMS.part
    60ae6cd4889f5c2922caa792cc0db13c5ba41c0fe0dc1c3de1624840ce9cd732e  guix-build-b849d6c51815/output/x86_64-apple-darwin/bitcoin-b849d6c51815-x86_64-apple-darwin-codesigning.tar.gz
    72c5a6fdf7a57ff2fb1a5ed0a58db24f9862b4a6c030118352555f6a4fc32d936  guix-build-b849d6c51815/output/x86_64-apple-darwin/bitcoin-b849d6c51815-x86_64-apple-darwin-unsigned.tar.gz
    89039796aaf9228c20215831e95c4fe8024a50bfee809608e9185c0ba4d18ac21  guix-build-b849d6c51815/output/x86_64-apple-darwin/bitcoin-b849d6c51815-x86_64-apple-darwin-unsigned.zip
    

    Split from #32764.

  2. guix: Remove `make-lld-wrapper`
    The LLD wrapper aims to add any missing `-rpath` flags. However, this
    is only required for native binaries, and is already handled by the
    native toolchain (currently `gcc-toolchain-14`).
    b849d6c518
  3. hebasto added the label Build system on Mar 20, 2026
  4. DrahtBot commented at 11:49 am on March 20, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK trevarj

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34948 (guix: Split manifests by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. trevarj commented at 7:51 pm on March 22, 2026: none
    ACK b849d6c
  6. fanquake commented at 3:58 am on March 23, 2026: member

    Split from #32764.

    Any particular reason? Seems fine to make all the related changes there.

  7. hebasto commented at 8:26 am on March 23, 2026: member

    Split from #32764.

    Any particular reason? Seems fine to make all the related changes there.

    Mainly to separate concerns. The cleanup and the functional changes in #32764 are unrelated to each other.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-30 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me