ci: Upgrade IWYU to 0.26 compatible with Clang 22 #34896

1. 
   hebasto commented at 5:05 pm on March 22, 2026: member

   This PR upgrades IWYU to 0.26 and removes mapping workarounds for issues that have been fixed upstream.
2. hebasto added the label Tests on Mar 22, 2026
3. 
   DrahtBot commented at 5:05 pm on March 22, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake
   Stale ACK	maflcko

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #34448 (ci, iwyu: Fix warnings in src/util and treat them as errors by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. ci: Upgrade IWYU to 0.26 compatible with Clang 22

   Additionally, removes mapping workarounds for issues that have been
   fixed upstream.

   0b489886f8
5. hebasto force-pushed on Mar 22, 2026
6. DrahtBot added the label CI failed on Mar 22, 2026
7. in src/kernel/coinstats.cpp:27 in 0b489886f8 outdated

   19@@ -20,11 +20,11 @@
   20 #include <util/overflow.h>
   21 #include <validation.h>
   22 
   23+#include <cstddef>
   24 #include <map>
   25 #include <memory>
   26 #include <span>
   27 #include <utility>
   28-#include <version>
   

   ---

   ---

   

   hebasto commented at 5:21 pm on March 22, 2026:

   These changes result from new symbol mapping for std::nullptr_t.
8. DrahtBot removed the label CI failed on Mar 22, 2026
9. in src/index/base.cpp:36 in 0b489886f8 outdated

   32@@ -33,6 +33,7 @@
   33 #include <cassert>
   34 #include <compare>
   35 #include <cstdint>
   36+#include <functional>
   

   ---

   ---

   

   hebasto commented at 6:46 pm on March 22, 2026:

   This header provides an implicit conversion from a lambda to std::function in https://github.com/bitcoin/bitcoin/blob/483769c0461b4c6d0b619de0e27c496dfc0ad734/src/index/base.cpp#L457
10. hebasto marked this as ready for review on Mar 22, 2026
11. in ci/test/00_setup_env_native_iwyu.sh:11 in 0b489886f8

     7@@ -8,7 +8,7 @@ export LC_ALL=C.UTF-8
     8 
     9 export CI_IMAGE_NAME_TAG="mirror.gcr.io/debian:trixie"  # To build codegen, CMake must be 3.31 or newer.
    10 export CONTAINER_NAME=ci_native_iwyu
    11-export TIDY_LLVM_V="21"
    12+export TIDY_LLVM_V="22"
    

    ---

    ---

    

    maflcko commented at 5:36 pm on March 24, 2026:

    unrelated nit: Could rename to IWYU_LLVM_V in a new commit, so that it is easier to grep for the separate meanings and separate uses?

    ---

    

    hebasto commented at 8:25 pm on March 24, 2026:

    Thanks! Done.
12. maflcko approved
13. 
    maflcko commented at 5:39 pm on March 24, 2026: member

    didn’t review the patch file. otherwise

    review ACK 0b489886f85ff0430ae838dbc6a87da201033644 📷

    Signature:

    0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    2trusted comment: review ACK 0b489886f85ff0430ae838dbc6a87da201033644 📷
    3aZjObg0/SSuhewYW3n5GnD5GVCxPK53sgwXD9e4H3GWJbETkgZRUFG9V+EsBxUaWWrfi3m6y016Awrnr6YRxAA==
    

14. ci: Rename `TIDY_LLVM_V` to `IWYU_LLVM_V` in IWYU-specific code 3129d4a693
15. 
    fanquake commented at 1:03 am on March 25, 2026: member

    ACK 3129d4a69345324de3658bf3a1cb5eee23f6bae8
16. DrahtBot requested review from maflcko on Mar 25, 2026
17. fanquake merged this on Mar 25, 2026
18. fanquake closed this on Mar 25, 2026

    ---

19. hebasto deleted the branch on Mar 25, 2026
20. hebasto referenced this in commit b15571940c on Mar 25, 2026

Contributors
hebasto DrahtBot maflcko fanquake

Review Requested
maflcko

Labels
Tests