The BlockManager reference in ContextualCheckBlockHeader is unused.
Fix this by removing it from the function parameter list.
Remove BlockManager reference argument in ContextualCheckBlockHeader invocations.
validation: Remove stale `BlockManager` param from `ContextualCheckBlockHeader` #35001
pull ismaelsadeeq wants to merge 1 commits into bitcoin:master from ismaelsadeeq:04-2026-remove-redundant-block-man changing 1 files +3 −3-
ismaelsadeeq commented at 1:42 AM on April 4, 2026: member
-
validation: Remove stale BlockManager param in ContextualCheckBlockHeader 851152e42a
- DrahtBot added the label Validation on Apr 4, 2026
-
DrahtBot commented at 1:43 AM on April 4, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK stratospher, maflcko If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #34895 (fuzz: Fuzzing harnesses for ActivateBestChainStep and ActivateBestChain by RobinDavid)
- #30342 (kernel, logging: Pass Logger instances to kernel objects by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
stratospher commented at 7:47 AM on April 4, 2026: contributor
ACK 851152e. not used anymore since checkpoints were removed in 3c5d1a4.
-
maflcko commented at 8:39 AM on April 7, 2026: member
lgtm ACK 851152e42a4cc5933234a1fc2ab52ba3e389e31c
- fanquake merged this on Apr 7, 2026
- fanquake closed this on Apr 7, 2026
- ismaelsadeeq deleted the branch on Apr 7, 2026
Contributors
Labels