ci: Match VCPKG_HOST_TRIPLET to VCPKG_TARGET_TRIPLET #35031

1. 
   hebasto commented at 9:27 am on April 8, 2026: member

   Using a non-default target triplet in #34883 introduced a regression because packages with "host": true in their vcpkg configurations were still picking up the default x64-windows triplet, effectively building both release and debug packages.

   This PR fixes this regression by setting VCPKG_HOST_TRIPLET explicitly.

   Upstream issue: https://github.com/microsoft/vcpkg/issues/50927.

2. ci: Match `VCPKG_HOST_TRIPLET` to `VCPKG_TARGET_TRIPLET`

   Using a non-default target triplet introduced a regression because
   packages with `"host": true` in their vcpkg configurations were still
   picking up the default `x64-windows` triplet, effectively building both
   release and debug packages.
   
   Fix this regression by setting `VCPKG_HOST_TRIPLET` explicitly.

   c74c6cfd84
3. hebasto added the label Windows on Apr 8, 2026
4. hebasto added the label Tests on Apr 8, 2026
5. 
   DrahtBot commented at 9:28 am on April 8, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hodlinator

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #31507 (build: Use clang-cl to build on Windows natively by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   hebasto commented at 9:28 am on April 8, 2026: member

   cc @hodlinator
7. 
   hebasto commented at 10:07 am on April 8, 2026: member

   In my personal repo, the “Generate build system” step now takes about 37 minutes: https://github.com/hebasto/bitcoin/actions/runs/24128103409/job/70397606546.

   Additionally, all vcpkg packages show the same log output:

   0-- Configuring x64-windows-release
   1-- Building x64-windows-release-rel
   

8. maflcko added this to the milestone 31.0 on Apr 8, 2026
9. 
   hebasto commented at 10:16 am on April 8, 2026: member

   I don’t think this PR needs the 31.0 milestone, since the regression only affects the master branch.
10. fanquake removed this from the milestone 31.0 on Apr 8, 2026
11. maflcko added this to the milestone 32.0 on Apr 8, 2026
12. 
    maflcko commented at 10:27 am on April 8, 2026: member

    Ah, sorry, I wanted to tag 32.x to clarify this does not need backport, but my cursor slipped to 31.x.
13. 
    hodlinator commented at 12:13 pm on April 8, 2026: contributor

    utACK c74c6cfd8404449029cae163531056e7493fe80f

    Notable: we use VCPKG_HOST_TRIPLET while the workaround in the upstream PR only mentions VCPKG_DEFAULT_HOST_TRIPLET.

    Compared raw logs between:

    • March - https://github.com/bitcoin/bitcoin/actions/runs/23361871973/job/67966938087?pr=34883#step:8:211 (source: #34883#pullrequestreview-3999718094)
    • April - https://github.com/hebasto/bitcoin/actions/runs/24128103409/job/70397606546#step:8:2 (this PR, source: #35031 (comment))

    The former contains multiple instances of “x64-windows-dbg”, the latter does not. :+1:

    ---

    The former also has both:

    02026-03-20T20:46:50.5810574Z   * qtbase[brotli,concurrent,core,dbus,dnslookup,doubleconversion,freetype,gui,harfbuzz,icu,jpeg,network,opengl,openssl,pcre2,png,sql,sql-psql,sql-sqlite,testlib,thread,widgets,zstd]:x64-windows@6.9.1 -- git+https://github.com/microsoft/vcpkg@be98b37ac43fb19787d8eb594a22343810259f17
    12026-03-20T20:46:50.5814380Z     qtbase[core,doubleconversion,gui,network,png,testlib,thread,widgets]:x64-windows-release@6.9.1 -- git+https://github.com/microsoft/vcpkg@be98b37ac43fb19787d8eb594a22343810259f17
    

    while the latter only has:

    02026-04-08T09:25:58.0831447Z     qtbase[core,doubleconversion,gui,network,png,testlib,thread,widgets]:x64-windows-release@6.9.1 -- git+https://github.com/microsoft/vcpkg@be98b37ac43fb19787d8eb594a22343810259f17
    

    meaning it doesn’t need to modify qtbase any longer. Not sure if that’s an aspect of this PR though.

14. fanquake merged this on Apr 9, 2026
15. fanquake closed this on Apr 9, 2026

    ---

16. hebasto deleted the branch on Apr 9, 2026

Contributors
hebasto DrahtBot maflcko hodlinator

Labels
Windows Tests

Milestone
32.0