Summary
Similar to #32958 and motivated by #32958#pullrequestreview-3107029707
We now are using util::Expected and removed TransactionError::OK
This makes the enum less confusing because it no longer includes OK.
Refactor: Updated TransactionError to use util::Expected and removed TransactionError:OK #35105
pull kevkevinpal wants to merge 2 commits into bitcoin:master from kevkevinpal:TransactionErrorToTransactionResponse changing 8 files +44 −46-
kevkevinpal commented at 2:18 PM on April 18, 2026: contributor
- DrahtBot added the label Refactoring on Apr 18, 2026
-
DrahtBot commented at 2:18 PM on April 18, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers Approach NACK janb84 If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #34806 (refactor: logging: Various API improvements by ajtowns)
- #33117 (Interfaces: Expose UTXO Snapshot Loading and Add Progress Notifications by D33r-Gee)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
janb84 commented at 9:25 AM on April 20, 2026: contributor
Approach NACK
I do not think this is the best future proof way to accomplish the goal. In C++ 23
std::expectedis introduced, which is a better way (imo) to do for explicit error handling. E.g link link2Yes we are currently on C++ 20 but a "polyfill"
std::expectedis already introduced in the code asutil::Expected<T, E>This makes the upgrade path to C++23 an easy search and replace and is a better way to do explicit error handling / remove the
okfrom the errors. -
refactor: BroadcastTransaction and HandleATMPError now uses util::Expected bc5f135733
-
refactor: remove unused TransactionError:OK 592a8338b1
- kevkevinpal force-pushed on Apr 28, 2026
-
kevkevinpal commented at 12:12 PM on April 28, 2026: contributor
- kevkevinpal renamed this:
Refactor: Updated TransactionError to TransactionResponse
Refactor: Updated TransactionError to use util::Expected and removed TransactionError:OK
on Apr 28, 2026 -
DrahtBot commented at 4:05 AM on May 22, 2026: contributor
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
- DrahtBot added the label Needs rebase on May 22, 2026
