fuzz: remove redundant CScript method calls from script harness #35127

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2026-04-fuzz-script changing 2 files +1 −7
  1. brunoerg commented at 12:36 AM on April 21, 2026: contributor

    The script harness was calling GetSigOpCount, HasValidOps, IsPayToAnchor, IsPayToScriptHash, IsPayToWitnessScriptHash, and IsPushOnly on the fuzzed CScript. All of these are already covered by the script_ops harness, which is the dedicated harness for CScript member methods. Also, add the missing IsPayToAnchor call to script_ops so the move preserves coverage.

  2. fuzz: remove redundant CScript method calls from script harness
    The script harness was calling GetSigOpCount, HasValidOps,
    IsPayToAnchor, IsPayToScriptHash, IsPayToWitnessScriptHash, and
    IsPushOnly on the fuzzed CScript. All of these are already covered
    by the script_ops harness, which is the dedicated harness for
    CScript member methods.
    
    Also add the missing IsPayToAnchor call to script_ops so the move
    preserves coverage.
    c9d8582235
  3. DrahtBot added the label Fuzzing on Apr 21, 2026
  4. DrahtBot commented at 12:36 AM on April 21, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32729 (test,refactor: extract script template helpers & widen sigop count coverage by l0rinc)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. maflcko commented at 5:04 AM on April 21, 2026: member

    lgtm ACK c9d8582235acf966e7e7bd47483624b4fc028cdd

Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me