rpc: document maxconf default value in wallet RPCs #35137

pull GerardoTaboada wants to merge 1 commits into bitcoin:master from GerardoTaboada:wallet/document-maxconf-default changing 1 files +4 −4

GerardoTaboada commented at 2:59 AM on April 22, 2026: none
fundrawtransaction, send, sendall, and walletcreatefundedpsbt all document maxconf as Optional::OMITTED, while the sibling parameter minconf explicitly documents its default of 0. The actual default for maxconf is 9999999 (DEFAULT_MAX_DEPTH in src/wallet/coincontrol.h).

listunspent already documents this correctly:
```
{"maxconf", RPCArg::Type::NUM, RPCArg::Default{9999999}, "The maximum confirmations to filter"},
```
This PR applies the same pattern to the four affected RPCs for consistency.
DrahtBot added the label RPC/REST/ZMQ on Apr 22, 2026
DrahtBot commented at 2:59 AM on April 22, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
sedited commented at 6:40 AM on April 22, 2026: contributor

Please drop the unrelated first commit.

rpc: document maxconf default value in wallet RPCs

fundrawtransaction, send, sendall, and walletcreatefundedpsbt all had
maxconf documented as Optional::OMITTED, while the sibling parameter
minconf explicitly documented its default of 0. The actual default for
maxconf is 9999999 (DEFAULT_MAX_DEPTH from coincontrol.h), which is
already documented correctly in listunspent. Make all four RPCs
consistent with listunspent by using RPCArg::Default{9999999}.

90dc47fb77

GerardoTaboada force-pushed on Apr 22, 2026
GerardoTaboada commented at 2:48 PM on April 22, 2026: none

Done, removed the unrelated commit via rebase.

Contributors

Labels

rpc: document maxconf default value in wallet RPCs #35137

Reviews