Motivation: Currently, node operators lack direct visibility when a replacement transaction (RBF) contains outputs that are technically unspendable (OP_RETURN or burn scripts). This creates a diagnostic blind spot during periods of high mempool pressure. Description of change: I have added a validation loop within src/validation.cpp that checks the vout of transactions undergoing RBF checks. By using scriptPubKey.IsUnspendable(), the node now logs these events under the RBF_MONITOR_AUDIT signal. Significance: Developer Experience: Provides better auditing tools for mempool policy and resource allocation. User Experience: Helps node operators on constrained hardware (4-core/8GB RAM) identify CPU overhead caused by high-volume unspendable output processing. Tests: This has been manually verified on a local node during IBD (Initial Block Download) and high-traffic synchronization.
policy: log unspendable outputs in RBF replacement checks #35160
pull ericsmith00759-a11y wants to merge 1 commits into bitcoin:master from ericsmith00759-a11y:patch-4 changing 1 files +5 −0-
ericsmith00759-a11y commented at 9:47 AM on April 26, 2026: none
-
050f0ebe72
git add src/validation.cpp git commit -m "policy: log unspendable outputs in RBF replacement checks"
git push -f origin master
-
DrahtBot commented at 9:47 AM on April 26, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
dergoegge commented at 1:11 PM on April 27, 2026: member
This looks entirely LLM generated without real understanding from the author, and should be closed.
-
sedited commented at 1:16 PM on April 27, 2026: contributor
I agree, this will take a couple of review cycles to get right for a very low impact change. Given our constrained review resources, I don't think that is worth the review time. Closing.
- sedited closed this on Apr 27, 2026
Contributors