Add test coverage for sigop counting in P2SH spends in test_witness_sigops(), addressing the existing TODO.
The test mirrors the existing P2WSH cases by constructing transactions that:
Sigop accounting is adjusted for P2SH by applying the legacy 4x cost factor.
This ensures sigop limits are enforced consistently across both witness and P2SH paths.
Implement the TODO in test_witness_sigops by adding tests
for sigop accounting in P2SH spends.
Mirror the existing P2WSH cases to verify behavior below,
at, and above the sigop limit. Adjust calculations for the
legacy 4x sigop cost used in P2SH.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | haishmg |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Possible places where comparison-specific test macros should replace generic comparisons:
assert p2sh_extra_sigops_available < 100 -> consider using assert_greater_than(100, p2sh_extra_sigops_available) instead of a bare comparison assert<sup>2026-04-27 08:25:57</sup>
ACK f3f1a703137bd9adf492dd67cda3779ae3a2cd8e
Reviewed the added P2SH sigop coverage in test_witness_sigops. The new cases mirror the existing P2WSH boundary checks and exercise below-limit, over-limit, and exact-limit P2SH spends with legacy sigop cost accounting.
Ran locally on macOS arm64:
build/test/functional/p2p_segwit.pygit diff --check upstream/master...HEADI also tried test/lint/lint-python.py test/functional/p2p_segwit.py, but it skipped locally because lief is not installed.