fuzz: connman: strengthen assertions and extend coverage #35220

pull brunoerg wants to merge 5 commits into bitcoin:master from brunoerg:2026-04-fuzz-connman-asserts changing 1 files +54 −13
  1. brunoerg commented at 8:39 AM on May 6, 2026: contributor

    This PR improves the connman fuzz target by replacing some "(void)" calls with actual invariant checks, adding coverage for previously uncovered methods, and exercising more initialization states.

    • Set m_local_services, m_use_addrman_outgoing, and m_max_automatic_connections via fuzzed values before Init() to explore more startup configurations.

    • Add network activity and outbound-bytes invariants.

    • Add AddNode/RemoveAddedNode invariants: e.g. a successful AddNode increases GetAddedNodeInfo() by one; adding the same node again must fail; a subsequent RemoveAddedNode must succeed and restore the original count.

    • Add coverage for AddLocalServices/RemoveLocalServices.

  2. fuzz: connman: add network activity invariants dd2eca0f34
  3. fuzz: connman: set m_local_services/m_use_addrman_outgoing/m_max_automatic_connections de573fa784
  4. fuzz: connman: add AddNode/RemoveAddedNode invariants 28648e31c6
  5. fuzz: connman: add outbound-bytes invariants a4287bd6fc
  6. fuzz: connman: cover AddLocalServices/RemoveLocalServices dfd3744b7b
  7. DrahtBot added the label Fuzzing on May 6, 2026
  8. DrahtBot commented at 8:39 AM on May 6, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35220.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34934 (fuzz: exercise ForNode/ForEachNode callbacks in connman fuzz harness by frankomosh)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-11 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me