Adds support for BIP 434.
BIP 434 Support: Peer feature negotiation #35221
pull ajtowns wants to merge 6 commits into bitcoin:master from ajtowns:202604-bip434-support changing 16 files +180 −17-
ajtowns commented at 11:48 AM on May 6, 2026: contributor
-
DrahtBot commented at 11:48 AM on May 6, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35221.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #28463 (p2p: Increase inbound capacity for block-relay only connections by mzumsande)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
LLM Linter (✨ experimental)
Possible places where named args for integral literals may be used (e.g.
func(x, /*named_arg=*/0)in C++, andfunc(x, named_arg=0)in Python):MakeAndPushFeature(pfrom, NetMsgFeature::DUMMY, uint32_t{0})insrc/net_processing.cpp
<sup>2026-05-06 19:58:52</sup>
- ajtowns force-pushed on May 6, 2026
- DrahtBot added the label CI failed on May 6, 2026
-
fjahr commented at 12:23 PM on May 6, 2026: contributor
Concept ACK
-
sedited commented at 12:43 PM on May 6, 2026: contributor
Concept ACK
- ajtowns force-pushed on May 6, 2026
- ajtowns force-pushed on May 6, 2026
-
cad323f630
serialize: string_view serialization
Allows `stream << sv` to serialize from a string_view directly, without converting to a string or similar first.
-
serialize: add LimitedVectorFormatter cda4d113d2
-
net: Add AdvertisedVersion() for protocol version advertised to a peer 88efda2743
-
f51cb08f70
BIP434: FEATURE message support
BIP434 defines FEATURE messages which are sent between VERSION and VERACK to indicate support for new P2P protocol features. This commit provides the infrastructure for easily using BIP434 negotiation when implementing such new P2P protocol features. Note that advertised protocol version is bumped to 70017, as per BIP434's specification.
-
test_framework: BIP 434 support a1fec832e5
-
35502ef92b
dummy bip434 feature
This is a dummy commit to ensure that everything compiles when it's used, will be dropped before PR is undrafted.
- DrahtBot added the label Needs rebase on May 6, 2026
- ajtowns force-pushed on May 6, 2026
- DrahtBot removed the label Needs rebase on May 6, 2026
