This one cast is harmless, but confusing. Also, in the past they have been brittle to the extend of triggering bugs. See commit 44afed4cd970ec38560ebb673c50b4f52da830c9. So remove this one recently introduced one.
refactor: [rpc] Remove confusing and brittle integral casts (take 3) #35223
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2605-rpc-cast-pfui changing 1 files +1 −1-
maflcko commented at 3:38 PM on May 6, 2026: member
-
refactor: [rpc] Remove confusing and brittle integral casts (take 3) fa864b937e
- DrahtBot added the label Refactoring on May 6, 2026
-
DrahtBot commented at 3:38 PM on May 6, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35223.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK fjahr, stickies-v, sedited If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
-
fjahr commented at 3:51 PM on May 6, 2026: contributor
ACK fa864b937e1b36f5a8fe989467360988a03637ec
- stickies-v approved
-
stickies-v commented at 3:56 PM on May 6, 2026: contributor
ACK fa864b937e1b36f5a8fe989467360988a03637ec
- sedited approved
-
sedited commented at 9:47 PM on May 6, 2026: contributor
ACK fa864b937e1b36f5a8fe989467360988a03637ec
- sedited merged this on May 6, 2026
- sedited closed this on May 6, 2026
- maflcko deleted the branch on May 7, 2026
Contributors
Labels