To https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/198
contrib: mv verify-commits/pre-push-hook.sh to maintainer tools repo #35235
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2605-mv-contrib changing 1 files +0 −21-
maflcko commented at 10:20 AM on May 7, 2026: member
-
mv contrib/verify-commits/pre-push-hook.sh to maintainer tools repo 888857c551
-
DrahtBot commented at 10:20 AM on May 7, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35235.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK achow101, kevkevinpal, l0rinc If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- maflcko renamed this:
mv contrib/verify-commits/pre-push-hook.sh to maintainer tools repo
contrib: mv verify-commits/pre-push-hook.sh to maintainer tools repo
on May 7, 2026 - DrahtBot added the label Scripts and tools on May 7, 2026
-
achow101 commented at 11:42 AM on May 7, 2026: member
ACK 888857c55140e5cb1ec80837e9dec79d1362d04a
This is maintainer specific tooling which we've been moving to the maintainer tools repo. Also unclear if anyone is using it (I am not).
-
kevkevinpal commented at 2:44 PM on May 7, 2026: contributor
ACK 888857c
Makes sense to me, this seems like a maintainer-only tool and doesn't make sense to have in this repo.
The PR mentioned looks to be an exact replica of the file that was removed. I would prefer that https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/198 be merged prior to this PR being merged.
-
maflcko commented at 5:32 AM on May 8, 2026: member
I would prefer that bitcoin-core/bitcoin-maintainer-tools#198 be merged prior to this PR being merged.
If you have merge preference as a reviewer, you can first review the pull that should be merged first.
-
l0rinc commented at 7:37 AM on May 8, 2026: contributor
code review ACK 888857c55140e5cb1ec80837e9dec79d1362d04a
It's moved cleanly to https://github.com/bitcoin-core/bitcoin-maintainer-tools/pull/198#issuecomment-4404564014 I don't mind the merge order, the change is simple enough.
- achow101 merged this on May 8, 2026
- achow101 closed this on May 8, 2026
- achow101 referenced this in commit b063345915 on May 8, 2026
- maflcko deleted the branch on May 8, 2026
Contributors
Labels