psbt, test: remove address type restrictions in test #35279

pull rkrux wants to merge 1 commits into bitcoin:master from rkrux:psbt-todo changing 1 files +1 −1
  1. rkrux commented at 11:41 AM on May 13, 2026: contributor

    Because the corresponding Taproot fields were added in PSBT in #22558, so these restrictions are no longer necessary.

  2. psbt, test: remove address type restrictions in test
    Because the corresponding Taproot fields were added in PSBT in PR 22558, so
    these restrictions are no longer necessary.
    81348576cc
  3. DrahtBot commented at 11:41 AM on May 13, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35279.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK kevkevinpal, polespinasa, furszy

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #34917 (wallet: mark bip125-replaceable deprecated, remove walletrbf argument by rkrux)
    • #29278 (Wallet: Add maxfeerate wallet startup option by ismaelsadeeq)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. kevkevinpal commented at 3:18 PM on May 13, 2026: contributor

    ACK 8134857 Seems like a straightforward change to me.

  5. polespinasa approved
  6. polespinasa commented at 6:39 PM on May 13, 2026: member

    lgtm ACK 81348576cc411a63da295a10a3846302419a18e0

  7. furszy commented at 2:57 PM on May 19, 2026: member

    utACK 81348576cc411a63da295a10a3846302419a18e0

  8. fanquake merged this on May 19, 2026
  9. fanquake closed this on May 19, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-06-04 10:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me