test: Allow --usecli in more tests #35363

pull maflcko wants to merge 5 commits into bitcoin:master from maflcko:2605-test-use-cli-more changing 10 files +17 −20

maflcko commented at 3:56 PM on May 22, 2026: member

Some tests disallow to be run under --usecli. This reduces the coverage and risks that bugs in the bitcoin-cli go unnoticed.

The commits should be self-explanatory and can be reviewed and tested one-by-one.
test: Set TestNode url field early, so that feature_loadblock.py --usecli works fa4fc8c1d7
DrahtBot added the label Tests on May 22, 2026
DrahtBot commented at 3:56 PM on May 22, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35363.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK willcl-ark

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
DrahtBot added the label CI failed on May 22, 2026
willcl-ark commented at 9:00 PM on May 24, 2026: member

Looks like dbcrash needs to handle failure (when using cli) in the form of subprocess.CalledProcessError?
test: Stop node before modifying config to support rpc_users.py --usecli
Otherwise, bitcoin-cli will read the wrong config from the "future".
faf993ee44

Type	Reviewers
ACK	willcl-ark

test: use echojson to allow rpc_named_arguments.py --usecli

The echo and echojson RPCs are identical in the server. The only
difference is that echojson is in the client conversion table.

faf0f848ef

test: Catch CalledProcessError to support --usecli in feature_dbcrash.py fa8d4d5c35
test: Allow --usecli in tests that already support it fa24693819
maflcko force-pushed on May 26, 2026
DrahtBot removed the label CI failed on May 26, 2026
willcl-ark approved
willcl-ark commented at 6:54 AM on May 26, 2026: member

ACK fa24693819e054c4e795dcaa510f17a757421b9e

LGTM now. More usecli tests running in the Apline job 👍🏼
fanquake merged this on May 26, 2026
fanquake closed this on May 26, 2026
maflcko deleted the branch on May 26, 2026
maflcko commented at 10:05 AM on May 26, 2026: member

Looks like dbcrash needs to handle failure (when using cli) in the form of subprocess.CalledProcessError?

Right, but I forgot to apply it to verify_utxo_hash :sweat_smile:

Given that it is tedious, due to the non-determinism, to enumerate all possible exception types, errno values, etc on all platforms and all test configs, I went with an alternative fix in https://github.com/bitcoin/bitcoin/pull/35379
maflcko commented at 10:41 AM on May 26, 2026: member

About the remaining instances of supports_cli=False:

I think they are all about the bitcoin-cli client conversion table, so I think I'll move the relevant coverage to a dedicated sub-test (maybe in rpc_named_arguments.py), remove the coverage from each of those tests and then remove the unused supports_cli field.

Contributors

Labels