kernel: expose btck_transaction_input_get_script_sig #35382

pull pzafonte wants to merge 1 commits into bitcoin:master from pzafonte:kernel-api-txin-script-sig changing 4 files +32 −0
  1. pzafonte commented at 1:19 PM on May 26, 2026: contributor

    Silent payments scanning requires the public key from each eligible input. For P2PKH inputs, the public key is in scriptSig. Access to scriptSig is also needed to identify P2SH-P2WPKH inputs, whose public key is in the witness stack (see #35380).

    btck_transaction_input_get_script_sig serializes the scriptSig through btck_WriteBytes callback and is exposed on the C++ wrapper as GetScriptSig().

  2. kernel: expose btck_transaction_input_get_script_sig
    scriptSig carries the public key for legacy P2PKH and P2SH-P2WPKH
    inputs. Callers scanning for silent payments need access to it.
    74891d9558
  3. DrahtBot added the label Validation on May 26, 2026
  4. DrahtBot commented at 1:19 PM on May 26, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35382.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK stickies-v

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. stickies-v commented at 1:49 PM on May 26, 2026: contributor

    Concept ACK. Seems to me like this would be more productive to bundle with #35380, though. Would prefer closing this.

  6. pzafonte closed this on May 26, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-31 17:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me