Since the autotools switch, the values for build-time constants CLIENT_VERSION_* and COPYRIGHT_YEAR are now defined in two places.
This seems a bit pointless to me. If both places have to be updated for every release, this only gives more values to update (and potentially forget). Or am I misunderstanding something?
Can we settle on one? If so, which one?
My vote for the clientversion.h.
The advantage of putting the version and such at a higher level in the build system is that the version can be used in other generated scripts, and it can be passed as parameter to commands. I guess that was the motivation. It doesn't appear to be used for that right now, though.
@laanwj I did it this way in the autotools change because I was afraid that some would be nervous about changing too much at once. I had planned a cleanup afterwards that never happened.
Indeed, it should happen in configure.ac. As you suggested, the reason for doing it here is that it means there's nothing to sync after a bump (installer scripts, packaging, tarball versions, etc.).
I'll work ok a PR.
