doc: warn about -bind and dedicated Tor socket in tor.md #35428

pull fernandguil wants to merge 1 commits into bitcoin:master from fernandguil:doc/tor-bind-onion-socket-warning changing 1 files +10 −0
  1. fernandguil commented at 10:05 PM on May 31, 2026: contributor

    Fixes #33458

    Problem

    When -bind is used to specify listening addresses without explicitly including 127.0.0.1:8334=onion, Bitcoin Core does not create a dedicated Tor socket. The automatic onion service is instead routed to the public IPv4 port, making it impossible for the node to distinguish incoming Tor connections from regular IPv4 connections. The result is that -netinfo and getnetworkinfo silently miscount Tor inbound connections as IPv4, with no indication that anything is wrong.

    Fix

    Add a note to the automatic onion service section of doc/tor.md explaining this behavior and the two ways to avoid it:

    • explicitly add -bind=127.0.0.1:8334=onion alongside other -bind entries
    • or disable the automatic onion service with -listenonion=0
  2. doc: warn about -bind and dedicated Tor socket in tor.md
    When -bind is used without explicitly including 127.0.0.1:8334=onion,
    the dedicated Tor socket is not created and incoming Tor connections are
    miscounted as IPv4 in -netinfo and getnetworkinfo. Add a note to the
    automatic onion service section explaining this behavior and how to avoid
    it.
    
    Fixes #33458
    e7f3dd56b0
  3. DrahtBot added the label Docs on May 31, 2026
  4. DrahtBot commented at 10:05 PM on May 31, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35428.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. fanquake commented at 10:26 AM on June 1, 2026: member

    Duplicate of #34892.

  6. fanquake closed this on Jun 1, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-06-02 01:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me