test: introduce NodeSigner, run feature_taproot.py without wallet compiled #35438

pull theStack wants to merge 2 commits into bitcoin:master from theStack:202605-test-feature_taproot-w/o-wallet changing 4 files +53 −20
  1. theStack commented at 9:57 PM on June 1, 2026: contributor

    This PR introduces a simple NodeSigner wallet replacement class that delegates signing to a specified node via the signrawtransactionwithkey RPC. Note that this is fundamentally different to MiniWallet, as it allows spending standard output types (P2PKH, P2WPKH, P2SH-P2WPKH, P2TR) and operates on already existing raw transactions, rather than allowing to create them from scratch (though support for that could still be added later).

    A NodeSigner instance is plugged into the taproot functional test (feature_taproot.py) in order to allow running without having the Bitcoin Core wallet compiled. This was done with the intention to change the nature of this functional test as little as possible, as it seems that the variety of additional (pre-taproot) output script types and a rather sophisticated scheme for deriving amounts (including change) is desired -- if this is not considered relevant, a more invasive replacement using MiniWallet might also be a possible alternative.

  2. test: return full keypair from `getnewdestination` helper
    This can be useful for spending funds that are received at the created
    address. Preparatory for the next commit, which modifies the taproot
    functional test to work without the Bitcoin Core wallet compiled in.
    b1ecf425bd
  3. test: introduce NodeSigner, run feature_taproot.py without wallet compiled
    Introduce a new simple `NodeSigner` wallet replacement that delegates
    signing to a specified node via the `signrawtransactionwithkey` RPC,
    and plug in that new class to the functional test feature_taproot.py,
    so that it can be ran without the Bitcoin Core wallet compiled.
    fc9c8b6bc7
  4. DrahtBot added the label Tests on Jun 1, 2026
  5. DrahtBot commented at 9:57 PM on June 1, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35438.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK brunoerg

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  6. brunoerg commented at 1:59 PM on June 3, 2026: contributor

    Concept ACK

Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-06-04 10:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me