A discussion in the review of #35443 PR brought this test to my attention.
The test needs multiple wallets that can be created on a single node, multiple nodes are not required.
As there is a cost associated with setting-up and tearing-down nodes, this patch helps in reducing the test time as well.
The test needs multiple wallets that can be created on a single node, multiple
nodes are not required.
As there is a cost associated with setting-up and tearing-down nodes, this patch
helps in reducing the test time as well.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35462.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | ekzyis, polespinasa, sedited |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
ACK 5b65e312701165d83e7e4636c2b6882825674b47
The test needs multiple wallets that can be created on a single node, multiple nodes are not required.
Makes sense to me.
As there is a cost associated with setting-up and tearing-down nodes, this patch helps in reducing the test time as well.
Compared test time between 5b65e312701165d83e7e4636c2b6882825674b47 and master (47da4f9b716). It's consistently below 1 second on 5b65e312701165d83e7e4636c2b6882825674b47. On 47da4f9b716, it can take more than two seconds.
lgtm ACK 5b65e312701165d83e7e4636c2b6882825674b47
feel-free-to-ignore-nit: Would like a comment when importing the descriptor mentioning that only one node is used for efficiency, but ideally this is happening on different nodes.
ACK 5b65e312701165d83e7e4636c2b6882825674b47