The timestamp 1598887952 is used as the initial value of the node's mocked wall-clock in TestChain100Setup. Comment its UTC date to make the magic number more readable.
test: make TestChain100Setup's m_clock timestamp more readable #35538
pull HowHsu wants to merge 1 commits into bitcoin:master from HowHsu:fix-a-nit-of-m_clock changing 1 files +1 −1-
HowHsu commented at 5:59 PM on June 15, 2026: contributor
-
58cc2a0453
test: make TestChain100Setup's m_clock timestamp more readable
The timestamp 1598887952 is used as the initial value of the node's mocked wall-clock in TestChain100Setup. Comment its UTC date to make the magic number more readable.
- DrahtBot added the label Tests on Jun 15, 2026
-
DrahtBot commented at 5:59 PM on June 15, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35538.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 6:49 AM on June 16, 2026: member
lgtm ACK 58cc2a0453df87a3fa17dc1586f2cf91f72a9ad7
From #35497 (review) and #35497 (review)
-
HowHsu commented at 7:22 AM on June 16, 2026: contributor
lgtm ACK 58cc2a0
From #35497 (comment) and #35497 (comment)
Sorry for missing that, and thanks for pointing it out.
- fanquake merged this on Jun 16, 2026
- fanquake closed this on Jun 16, 2026
