See: #35536 (comment)
SteadyClockContext and FakeNodeClock are both LimitOne RAII helpers that mock a clock in tests -- the steady clock and the node clock, respectively. Rename the former so the two follow a consistent FakeXClock naming scheme.
scripted-diff: Rename SteadyClockContext to FakeSteadyClock #35559
pull HowHsu wants to merge 1 commits into bitcoin:master from HowHsu:fake-steady-clock changing 5 files +9 −9-
HowHsu commented at 7:17 AM on June 18, 2026: contributor
-
855a3fee88
scripted-diff: Rename SteadyClockContext to FakeSteadyClock
SteadyClockContext and FakeNodeClock are both LimitOne RAII helpers that mock a clock in tests -- the steady clock and the node clock, respectively. Rename the former so the two follow a consistent FakeXClock naming scheme. -BEGIN VERIFY SCRIPT- sed -i 's/SteadyClockContext/FakeSteadyClock/g' $(git grep -l SteadyClockContext) -END VERIFY SCRIPT-
- DrahtBot added the label Refactoring on Jun 18, 2026
-
DrahtBot commented at 7:17 AM on June 18, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35559.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 7:34 AM on June 18, 2026: member
Can you please remove the script from the pull message? I haven't tested this, but the pull message will be the commit message of the merge commit, and a script without a marker will likely lead to lint failures after merge.
-
maflcko commented at 7:36 AM on June 18, 2026: member
lgtm ACK 855a3fee8829447ca580d01fb96bff8d4eaf30db
Small diff to use a single naming scheme.
-
HowHsu commented at 7:58 AM on June 18, 2026: contributor
Can you please remove the script from the pull message? I haven't tested this, but the pull message will be the commit message of the merge commit, and a script without a marker will likely lead to lint failures after merge.
Thanks.
-
HowHsu commented at 8:00 AM on June 18, 2026: contributor
I think this should be updated and merged after https://github.com/bitcoin/bitcoin/pull/35536
