Problem: I often hit a timeout in feature_reindex.py when running functional tests locally in parallel in debug mode (especially on battery or in power-saving mode).
Fix: Increase the test-local RPC timeout for the reindex mining setup.
test: raise `feature_reindex` RPC timeout #35576
pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/raise-reindex-mining-rpc-timeout changing 1 files +1 −0-
l0rinc commented at 5:33 PM on June 21, 2026: contributor
-
9e6546c517
test: raise reindex mining RPC timeout
`feature_reindex.py` mines a long chain before restarting during reindex. Bump its local RPC timeout to avoid client timeouts in parallel debug-mode runs.
- DrahtBot renamed this:
test: raise `feature_reindex` RPC timeout
test: raise `feature_reindex` RPC timeout
on Jun 21, 2026 - DrahtBot added the label Tests on Jun 21, 2026
-
DrahtBot commented at 5:33 PM on June 21, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35576.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
mercie-ux commented at 5:33 AM on June 22, 2026: none
ACK 9e6546c517
Mining 1500 blocks in one call is what triggers the timeout on slower machines. Doubling the timeout just for this test rather than globally seems like the right call.
- sedited approved
-
sedited commented at 1:53 PM on June 22, 2026: contributor
Never ran into this on my laptop, and I run the tests with debug builds very often, but seems fine.
ACK 9e6546c517cd8e97ca6f64bba812dec9257e0b89
-
l0rinc commented at 7:35 PM on June 23, 2026: contributor
I run the tests with debug builds very often
What's your parallelism level? I always over-subscribe since the tests aren't all CPU-bound, i.e.:
rm -rfd build && cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DBUILD_BENCH=ON && ninja -C build -j$(nproc) && \ CTEST_PARALLEL_LEVEL=30 ninja -C build test -j$(nproc) && \ build/test/functional/test_runner.py -j20(nproc=16 for me)
-
maflcko commented at 7:14 AM on June 25, 2026: member
lgtm.
Personally I set a higher optimization level, even on debug builds with something like:
-DAPPEND_CXXFLAGS='-fno-omit-frame-pointer -std=c++23 -O3 -g2' -DAPPEND_CFLAGS='-fno-omit-frame-pointer -O3 -g2' -DCMAKE_BUILD_TYPE=Debug, because I only care about the debug mode build definitions. However, it seems fine to bump the timeout of the test, assuming this is the only test that needs an adjustment. - fanquake merged this on Jun 25, 2026
- fanquake closed this on Jun 25, 2026
-
l0rinc commented at 10:29 PM on June 25, 2026: contributor
<img width="814" height="73" alt="image" src="https://github.com/user-attachments/assets/5037b30f-61a4-4ae7-890d-87c7cc90ce7e" />
finally!
- l0rinc deleted the branch on Jun 25, 2026
