cli: Fix multisig error message spacing #35617

pull MichaelRihani wants to merge 1 commits into bitcoin:master from MichaelRihani:codex/fix-bitcoin-tx-multisig-message changing 2 files +7 −1
  1. MichaelRihani commented at 12:57 PM on June 29, 2026: none

    This fixes a small user-facing error-message typo in bitcoin-tx.

    When outmultisig is given mismatched parameters, the current error joins the number of keys and "signatures" without a space, e.g. Required 4 of 3signatures.

    The change also adds coverage alongside the existing malformed outmultisig cases in bitcoin-util-test.json.

    Tested:

    • python3 -m json.tool test/functional/data/util/bitcoin-util-test.json
    • git diff --cached --check

    Not run:

    • test/functional/test_runner.py tool_utils.py, because cmake is not installed in this environment and there is no configured build directory.
  2. cli: Fix multisig error message spacing cd6f4e9a6f
  3. DrahtBot added the label Scripts and tools on Jun 29, 2026
  4. DrahtBot commented at 12:58 PM on June 29, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35617.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. pinheadmz commented at 1:17 PM on June 29, 2026: member

    This is an extremely small typo fix which we usually discourage since every PR review requires so much human and CI resources. But I also want to flag this

    cmake is not installed in this environment and there is no configured build directory.

    Sounds like PR was written by an LLM without any human understanding.

    I recommend closing this PR and finding more productive ways to contribute to the project.

  6. maflcko commented at 3:41 PM on June 29, 2026: member

    lgtm ACK cd6f4e9a6f981cce22c0ffa77cfa914d3bf7f2db

    Seems fine to fix a typo and add coverage.

    cc @m3dwards Looks like corecheck does not include bitcoin-util coverage, and maybe it should be added?


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-02 03:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me