doc: Update enum class constant naming style guide #35698

1. 
   maflcko commented at 8:13 AM on July 10, 2026: member

   Lately, it seems there are frequent scripted-diffs and refactors to rename ALL_CAPS enum class constant names to something else, due to third-party macro clashes. E.g.:

   • #35588
   • #35487
   • #34454
   • etc... (not listing the intermittent pull request force pushes that lead to early CI failures due to macro clashes)

   Try to steer away from ALL_CAPS here by discouraging it in new code.

2. doc: Update enum class constant naming style guide fad5809cb9
3. DrahtBot added the label Docs on Jul 10, 2026
4. 
   DrahtBot commented at 8:13 AM on July 10, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35698.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline and AI policy for information on the review process.

   Type	Reviewers
   ACK	hebasto, pablomartin4btc, stickies-v, yuvicc, musaHaruna

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

5. hebasto approved
6. 
   hebasto commented at 9:58 AM on July 10, 2026: member

   ACK fad5809cb92329f58c12679d0e276fe0769b5845.

7. 
   pablomartin4btc commented at 1:11 PM on July 10, 2026: member

   ACK fad5809cb92329f58c12679d0e276fe0769b5845

   Checked against the C++ Core Guidelines ("Don’t use ALL_CAPS for enumerators" - "Reason Avoid clashes with macros") also referenced in the notes.

8. sedited requested review from hodlinator on Jul 10, 2026
9. stickies-v approved
10. 
    stickies-v commented at 2:57 PM on July 10, 2026: contributor

    ACK fad5809cb92329f58c12679d0e276fe0769b5845

11. 
    yuvicc commented at 5:08 PM on July 10, 2026: contributor

    ACK fad5809cb92329f58c12679d0e276fe0769b5845

12. 
    musaHaruna commented at 5:01 PM on July 11, 2026: contributor

    ACK fad5809

Review Requested
hodlinator