kernel: handle null mempool on chainstate deletion #35753

pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/delete-chainstate-null-mempool changing 2 files +10 −1

l0rinc commented at 2:30 AM on July 20, 2026: contributor
Problem: Kernel creates a ChainstateManager without a mempool, while AppInitMain() supplies one for node applications. If chainstate wiping is enabled and the data directory contains a saved AssumeUTXO snapshot, LoadChainstate() calls DeleteChainstate(), which dereferences the snapshot's null mempool pointer.

Fix: Accept a missing mempool when deleting the snapshot, matching the existing check in AddChainstate().

<details> <summary>Failure without the fix</summary>
```
unknown location:0: fatal error: in "validation_chainstatemanager_tests/chainstatemanager_delete_chainstate_no_mempool": memory access violation at address: 0x48: invalid permissions
```
</details>

validation: handle null mempool on delete

Kernel can create a `ChainstateManager` without a mempool.
Deleting an AssumeUTXO chainstate then dereferences the previous chainstate's null mempool pointer.

Allow the previous chainstate to have no mempool, matching `AddChainstate()`.
Cover the reindex/wipe lifecycle.

a99b27f192

DrahtBot added the label Validation on Jul 20, 2026
DrahtBot commented at 2:31 AM on July 20, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35753.



Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

Contributors

l0rinc

DrahtBot

Labels

Validation

kernel: handle null mempool on chainstate deletion #35753

Code Coverage & Benchmarks

Reviews