doc: fix outdated i2p URLs in comments #35782

pull nebula-21 wants to merge 1 commits into bitcoin:master from nebula-21:fix-i2p-urls changing 5 files +14 −15
  1. nebula-21 commented at 9:43 AM on July 23, 2026: contributor

    This PR only updates URLs in comments, no functional changes. Motivation: While reviewing PR#35696 I discovered that some I2P related URLs needed a fix.

    For context I2P project transitioned from geti2p.net to i2p.net and i2pd.readthedocs.io now uses docs.i2pd.website.

    • One of the URLs is broken and returns 404, fixed with this one.
    • Another URL redirects from this to this and should be this one.
    • The rest of changed URLs are basically the new URLs without the redirection, so in case the projects stop redirecting the old URLs we will have the updated ones.
  2. DrahtBot added the label Docs on Jul 23, 2026
  3. DrahtBot commented at 9:44 AM on July 23, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35782.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK sedited
    Concept ACK polespinasa

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. in src/test/net_tests.cpp:257 in 777555b031
     253 | @@ -254,7 +254,7 @@ BOOST_AUTO_TEST_CASE(cnetaddr_basic)
     254 |  
     255 |      // I2P, valid but unsupported (56 Base32 characters)
     256 |      // See "Encrypted LS with Base 32 Addresses" in
     257 | -    // https://geti2p.net/spec/encryptedleaseset.txt
     258 | +    // https://i2p.net/en/docs/specs/b32encrypted
    


    sedited commented at 9:51 AM on July 23, 2026:

    Look like "Encrypted LS with Base 32 Addresses" no longer exists verbatim. I would remove that line and just leave the link before it inevitably rots again.


    nebula-21 commented at 10:10 AM on July 23, 2026:

    done

  5. polespinasa commented at 9:58 AM on July 23, 2026: member

    cACK

    Just randomly checked some of the links and the redirects seems to match the changes

  6. doc: fix outdated i2p URLs in comments 419f7427ee
  7. nebula-21 force-pushed on Jul 23, 2026
  8. DrahtBot added the label CI failed on Jul 23, 2026
  9. DrahtBot removed the label CI failed on Jul 23, 2026
  10. sedited approved
  11. sedited commented at 12:25 PM on July 23, 2026: contributor

    ACK 419f7427eee25b6428bbce88e4898e20db9fd13c

  12. DrahtBot requested review from polespinasa on Jul 23, 2026
  13. fanquake merged this on Jul 23, 2026
  14. fanquake closed this on Jul 23, 2026

  15. jonatack commented at 1:32 PM on July 23, 2026: member

    Post-merge ACK, looks like all the relevant URLs were updated.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-31 20:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me