util: Make LineReader consistently use string_view #35828

pull hodlinator wants to merge 3 commits into bitcoin:master from hodlinator:2026/07/LineReader changing 7 files +33 −35

hodlinator commented at 11:49 AM on July 28, 2026: contributor
3 commits changing LineReader:
- Avoid the duplicate check for \n happening inside RemoveSuffixView(). #35182 (review)
- Use string_view internally rather than 2 span::iterators.
- Stop accepting span<byte> inputs since internally and as outputs we treat them as strings.
Found while reviewing #35182.
util: LineReader - Don't include newline and acknowledge single-char \r
Due to the preceeding if-condition we know \n is always there.
e8eaa80ce2

util: Make LineReader consistently use string_views

Forcing the input through std::byte while always outputting strings was cumbersome.

Also changes LineReader to a class and makes the fields private.

5d5cdcd79d

util: LineReader - Drop support for raw std::byte spans

TorControlConnection and HTTPRemoteClient have been updated to use std::string receive buffers which mirrors approach in HTTPClient::ReadResponse().

dff44e4c8f

DrahtBot added the label Utils/log/libs on Jul 28, 2026
DrahtBot commented at 11:49 AM on July 28, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35828.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK pinheadmz, furszy, achow101

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #35829 (http: Make class fields private or convert to struct by hodlinator)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
pinheadmz approved

Type	Reviewers
ACK	pinheadmz, furszy, achow101

pinheadmz commented at 7:24 PM on July 28, 2026: member

ACK dff44e4c8f3070abe108965f216ec6b364ca882d

Built and tested on macos/arm64. Reviewed all changes. This PR provides a no-op refactor to the string utility used by HTTP and torcontrol, reducing casts, cleaning up the interface and removing a redundant \n-check.

<details><summary>Show Signature</summary>

pinheadmz's public key is on openpgp.org

</details>

furszy commented at 8:09 PM on July 29, 2026: member

ACK dff44e4c8f3070abe108965f216ec6b364ca882d
achow101 commented at 10:49 PM on July 29, 2026: member

ACK dff44e4c8f3070abe108965f216ec6b364ca882d
achow101 merged this on Jul 29, 2026
achow101 closed this on Jul 29, 2026

Contributors

Labels

Linked (view graph)

#35182 Replace libevent with our own HTTP and socket-handling implementation

util: Make LineReader consistently use string_view #35828

Code Coverage & Benchmarks

Reviews

Conflicts