test: Use throwing config parser getters without fallback #35846

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2607-test-config-no-fallback changing 5 files +34 −34
  1. maflcko commented at 1:52 PM on July 30, 2026: member

    Currently, the called getboolean member function is not the throwing https://docs.python.org/3/library/configparser.html#configparser.ConfigParser.getboolean, but a non-throwing member function on a dict-like proxy object.

    This is confusing and brittle, because tests shouldn't silently skip when a config key is missing. Instead, tests should loudly fail, e.g. when the config key is renamed in one place, but not the other.

  2. DrahtBot added the label Tests on Jul 30, 2026
  3. DrahtBot commented at 1:52 PM on July 30, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35846.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK jeanpablojp, willcl-ark

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35762 (test: optionally run functional tests via CTest by willcl-ark)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. DrahtBot added the label CI failed on Jul 30, 2026
  5. maflcko force-pushed on Jul 31, 2026
  6. DrahtBot removed the label CI failed on Jul 31, 2026
  7. maflcko force-pushed on Aug 6, 2026
  8. DrahtBot added the label CI failed on Aug 6, 2026
  9. maflcko force-pushed on Aug 6, 2026
  10. DrahtBot removed the label CI failed on Aug 7, 2026
  11. test: Write true/false values in config.ini
    Omitting values is brittle, because a name mismatch can not be
    distinguished from a falsy (omitted) value.
    fa8acd57cd
  12. test: Use throwing config parser getters without fallback fabe100c2b
  13. maflcko force-pushed on Aug 7, 2026
  14. jeanpablojp commented at 12:16 PM on August 14, 2026: contributor

    tACK fabe100c2b33e03195c157a2eb267029e8532784

    All green. I agree that it should fail loud. In my tests I removed ENABLE_WALLET from config.ini and it fails with NoOptionError on this head; on master it silently skips.

  15. willcl-ark approved
  16. willcl-ark commented at 7:23 AM on August 17, 2026: member

    ACK fabe100c2b33e03195c157a2eb267029e8532784

  17. fanquake merged this on Aug 17, 2026
  18. fanquake closed this on Aug 17, 2026

  19. maflcko deleted the branch on Aug 17, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-24 07:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me